You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "aisk (via GitHub)" <gi...@apache.org> on 2026/05/25 12:54:56 UTC
[PR] [python] Add requests as dependency [paimon]
aisk opened a new pull request, #7960:
URL: https://github.com/apache/paimon/pull/7960
### Purpose
Currently requests is required to using Paimon, otherwise it will raise error when importing `paimon` on current main branch:
```
>>> import pypaimon
Traceback (most recent call last):
File "<python-input-0>", line 1, in <module>
import pypaimon
File "/home/asaka/paimon/paimon-python/pypaimon/__init__.py", line 26, in <module>
from pypaimon.catalog.catalog_factory import CatalogFactory
File "/home/asaka/paimon/paimon-python/pypaimon/catalog/catalog_factory.py", line 23, in <module>
from pypaimon.catalog.filesystem_catalog import FileSystemCatalog
File "/home/asaka/paimon/paimon-python/pypaimon/catalog/filesystem_catalog.py", line 45, in <module>
from pypaimon.table.file_store_table import FileStoreTable
File "/home/asaka/paimon/paimon-python/pypaimon/table/file_store_table.py", line 25, in <module>
from pypaimon.read.read_builder import ReadBuilder
File "/home/asaka/paimon/paimon-python/pypaimon/read/read_builder.py", line 20, in <module>
from pypaimon.common.predicate import Predicate
File "/home/asaka/paimon/paimon-python/pypaimon/common/predicate.py", line 29, in <module>
from pypaimon.manifest.schema.simple_stats import SimpleStats
File "/home/asaka/paimon/paimon-python/pypaimon/manifest/schema/simple_stats.py", line 22, in <module>
from pypaimon.table.row.generic_row import GenericRow
File "/home/asaka/paimon/paimon-python/pypaimon/table/row/generic_row.py", line 28, in <module>
from pypaimon.table.row.blob import BlobData
File "/home/asaka/paimon/paimon-python/pypaimon/table/row/blob.py", line 24, in <module>
from pypaimon.common.uri_reader import UriReader, FileUriReader
File "/home/asaka/paimon/paimon-python/pypaimon/common/uri_reader.py", line 23, in <module>
import requests
ModuleNotFoundError: No module named 'requests'
```
With the latest release of `pypaimon` on PyPI, we can import `pypaimon`, but `import CatalogFactory from pypaimon` will raise the same error.
Adding `requests` to `requirements.txt` can resolve this error. `requests 2.21.0` was released in 2018, I think it's old enough to be used as the minimum version range.
### Tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [python] Add requests as dependency [paimon]
Posted by "XiaoHongbo-Hope (via GitHub)" <gi...@apache.org>.
XiaoHongbo-Hope commented on PR #7960:
URL: https://github.com/apache/paimon/pull/7960#issuecomment-4586834515
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [python] Add requests as dependency [paimon]
Posted by "XiaoHongbo-Hope (via GitHub)" <gi...@apache.org>.
XiaoHongbo-Hope commented on PR #7960:
URL: https://github.com/apache/paimon/pull/7960#issuecomment-4587117831
Thanks for raising and fixing the issue. I will include this fix in 1.4.2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [python] Add requests as dependency [paimon]
Posted by "XiaoHongbo-Hope (via GitHub)" <gi...@apache.org>.
XiaoHongbo-Hope merged PR #7960:
URL: https://github.com/apache/paimon/pull/7960
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [python] Add requests as dependency [paimon]
Posted by "aisk (via GitHub)" <gi...@apache.org>.
aisk commented on PR #7960:
URL: https://github.com/apache/paimon/pull/7960#issuecomment-4550742802
Currently, pypaimon is using a legacy `setup.py` and reading `dev/requirements.txt` as dependencies in it, so this PR could resolve the issue:
https://github.com/apache/paimon/blob/d2ce7ae5d3c853ed523f87fab0244aed531c1896/paimon-python/setup.py#L121-L134
I think we should upgrade to a modern way of managing dependencies (e.g., using `pyproject.toml` with or without uv), but I think that could happen in another PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org