You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Daniel Rall <dl...@collab.net> on 2006/07/13 09:02:03 UTC
Re: svn commit: r20617 - branches/1.4.x
I added it there first (and to the peg version), then changed it after
looking at similar sleeps for our other commands.
On Wed, 12 Jul 2006, jerenkrantz@tigris.org wrote:
> Author: jerenkrantz
> Date: Wed Jul 12 23:21:43 2006
> New Revision: 20617
>
> Modified:
> branches/1.4.x/STATUS
>
> Log:
> ...I would have added the sleep to svn_client_merge2, but this is fine too...
>
>
> Modified: branches/1.4.x/STATUS
> URL: http://svn.collab.net/viewvc/svn/branches/1.4.x/STATUS?pathrev=20617&r1=20616&r2=20617
> ==============================================================================
> --- branches/1.4.x/STATUS (original)
> +++ branches/1.4.x/STATUS Wed Jul 12 23:21:43 2006
> @@ -58,7 +58,7 @@
> Justification:
> Data loss is inexcusable.
> Votes:
> - +1: dlr
> + +1: dlr, jerenkrantz
Re: svn commit: r20617 - branches/1.4.x
Posted by Max Bowsher <ma...@ukf.net>.
Justin Erenkrantz wrote:
> On 7/23/06, Julian Foad <ju...@btopenworld.com> wrote:
>> >>Author: jerenkrantz
>> >>Date: Wed Jul 12 23:21:43 2006
>> >>New Revision: 20617
>> [...]
>> >>Log:
>> >>...I would have added the sleep to svn_client_merge2, but this is
>> fine too...
>>
>> Please change that to a better log message.
>
> Huh? It's a vote, dude. I'm not going to waste my time coming up
> with an entire commit log message that just adds a vote to STATUS...
That commit log says *nothing* about the change. To anyone viewing log
messages without changed path information, it's a total "huh!?" moment.
Convention, as expressed in the majority of previous commits, suggests
that ideally log messages tweaking STATUS should begin "* STATUS: ", or
if not, at least mention the word 'vote'.
If you don't want to "waste your time", you can always fall back on the
boring but at least minimally informative: "* STATUS: Vote.".
Max.
Re: svn commit: r20617 - branches/1.4.x
Posted by Julian Foad <ju...@btopenworld.com>.
Justin Erenkrantz wrote:
> On 7/23/06, Julian Foad <ju...@btopenworld.com> wrote:
>
>> Please change that to a better log message.
>
> Huh? It's a vote, dude. I'm not going to waste my time coming up
> with an entire commit log message that just adds a vote to STATUS...
Call me a boring old fuddy-duddy if you like.
To avoid wasting any more of your time, I've changed it for you. No need to
thank me :-)
- Julian
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r20617 - branches/1.4.x
Posted by Justin Erenkrantz <ju...@erenkrantz.com>.
On 7/23/06, Julian Foad <ju...@btopenworld.com> wrote:
> >>Author: jerenkrantz
> >>Date: Wed Jul 12 23:21:43 2006
> >>New Revision: 20617
> [...]
> >>Log:
> >>...I would have added the sleep to svn_client_merge2, but this is fine too...
>
> Please change that to a better log message.
Huh? It's a vote, dude. I'm not going to waste my time coming up
with an entire commit log message that just adds a vote to STATUS...
-- justin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r20617 - branches/1.4.x
Posted by Julian Foad <ju...@btopenworld.com>.
>> Author: jerenkrantz
>>Date: Wed Jul 12 23:21:43 2006
>>New Revision: 20617
[...]
>>Log:
>>...I would have added the sleep to svn_client_merge2, but this is fine too...
Please change that to a better log message.
Thanks,
- Julian
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org