You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@seata.apache.org by "xuxiaowei-com-cn (via GitHub)" <gi...@apache.org> on 2026/06/09 03:14:48 UTC
[PR] feature: server: spring-boot upgrade to 4.0.6 [incubator-seata]
xuxiaowei-com-cn opened a new pull request, #8137:
URL: https://github.com/apache/incubator-seata/pull/8137
https://github.com/redis/jedis/blob/master/docs/migration-guides/v3-to-v4.md
<!--
Licensed to the Apache Software Foundation (ASF) under one or more
contributor license agreements. See the NOTICE file distributed with
this work for additional information regarding copyright ownership.
The ASF licenses this file to You under the Apache License, Version 2.0
(the "License"); you may not use this file except in compliance with
the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
-->
<!-- Please make sure you have read and understood the contributing guidelines -->
- [ ] I have read the [CONTRIBUTING.md](https://github.com/apache/incubator-seata/blob/2.x/CONTRIBUTING.md) guidelines.
- [ ] I have registered the PR [changes](https://github.com/apache/incubator-seata/tree/2.x/changes).
### Ⅰ. Describe what this PR did
### Ⅱ. Does this pull request fix one issue?
<!-- If that, add "fixes #xxx" below in the next line, for example, fixes #97. -->
https://github.com/apache/incubator-seata/issues/8053
### Ⅲ. Why don't you add test cases (unit test/integration test)?
### Ⅳ. Describe how to verify it
### Ⅴ. Special notes for reviews
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] feature: server: spring-boot upgrade to 4.0.6 [incubator-seata]
Posted by "funky-eyes (via GitHub)" <gi...@apache.org>.
funky-eyes commented on code in PR #8137:
URL: https://github.com/apache/incubator-seata/pull/8137#discussion_r3472116636
##########
.github/workflows/build.yml:
##########
@@ -106,6 +106,7 @@ jobs:
if: matrix.java == '8'
run: |
./mvnw -T 4C clean test \
+ -pl '!server,!test-suite/test-new-version,!extensions/apm/apm-seata-skywalking-plugin' \
Review Comment:
Why don’t we use the same XML configuration approach as NamingServer and Console to skip compilation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] feature: server: spring-boot upgrade to 4.0.6 [incubator-seata]
Posted by "xuxiaowei-com-cn (via GitHub)" <gi...@apache.org>.
xuxiaowei-com-cn commented on code in PR #8137:
URL: https://github.com/apache/incubator-seata/pull/8137#discussion_r3472293225
##########
.github/workflows/build.yml:
##########
@@ -106,6 +106,7 @@ jobs:
if: matrix.java == '8'
run: |
./mvnw -T 4C clean test \
+ -pl '!server,!test-suite/test-new-version,!extensions/apm/apm-seata-skywalking-plugin' \
Review Comment:
Processed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] feature: server: spring-boot upgrade to 4.0.6 [incubator-seata]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #8137:
URL: https://github.com/apache/incubator-seata/pull/8137#issuecomment-4656002957
## [Codecov](https://app.codecov.io/gh/apache/incubator-seata/pull/8137?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 72.99%. Comparing base ([`d4e01da`](https://app.codecov.io/gh/apache/incubator-seata/commit/d4e01dabd47ddcef8a8ca4ff8b422ab228974c6c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`f128f2a`](https://app.codecov.io/gh/apache/incubator-seata/commit/f128f2a32c4dcb2b8a912d6a31d20d9e51e37299?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on 2.x.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## 2.x #8137 +/- ##
============================================
+ Coverage 72.77% 72.99% +0.21%
- Complexity 883 1146 +263
============================================
Files 1327 1151 -176
Lines 50769 42192 -8577
Branches 6058 5033 -1025
============================================
- Hits 36948 30798 -6150
+ Misses 10817 8906 -1911
+ Partials 3004 2488 -516
```
[see 243 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-seata/pull/8137/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
[](https://app.codecov.io/gh/apache/incubator-seata/pull/8137?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] feature: server: spring-boot upgrade to 4.0.6 [incubator-seata]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #8137:
URL: https://github.com/apache/incubator-seata/pull/8137#discussion_r3471700925
##########
server/src/test/java/org/apache/seata/server/logging/AppenderTest.java:
##########
@@ -24,33 +24,37 @@
import org.apache.seata.server.BaseSpringBootTest;
import org.apache.seata.server.logging.logback.appender.MetricLogbackAppender;
import org.junit.jupiter.api.Assertions;
-import org.junit.jupiter.api.BeforeAll;
import org.junit.jupiter.api.Test;
-import org.slf4j.impl.StaticLoggerBinder;
+import org.slf4j.LoggerFactory;
+import org.springframework.test.context.TestPropertySource;
import java.lang.reflect.Field;
import java.util.Iterator;
+@TestPropertySource(
+ properties = {
+ "logging.extend.logstash-appender.enabled=true",
+ "logging.extend.kafka-appender.enabled=true",
+ "logging.extend.kafka-appender.topic=test",
+ "logging.extend.metric-appender.enabled=true"
+ })
public class AppenderTest extends BaseSpringBootTest {
- @BeforeAll
- public static void init() {
- System.setProperty("logging.extend.logstash-appender.enabled", "true");
- System.setProperty("logging.extend.kafka-appender.enabled", "true");
- System.setProperty("logging.extend.kafka-appender.topic", "test");
- System.setProperty("logging.extend.metric-appender.enabled", "true");
- }
-
@Test
public void testAppenderEnabled() {
- LoggerContext lc = (LoggerContext) StaticLoggerBinder.getSingleton().getLoggerFactory();
+ LoggerContext lc = (LoggerContext) LoggerFactory.getILoggerFactory();
Iterator<Appender<ILoggingEvent>> appenderIterator =
lc.getLogger("ROOT").iteratorForAppenders();
+ boolean kafkaFound = false;
+ boolean metricFound = false;
+ boolean logstashFound = false;
+
while (appenderIterator.hasNext()) {
Appender<ILoggingEvent> appender = appenderIterator.next();
if (appender.getName().equals("KAFKA")) {
KafkaAppender<ILoggingEvent> kafkaAppender = (KafkaAppender<ILoggingEvent>) appender;
+ kafkaFound = true;
Review Comment:
This cast happens before any type check, so a misconfigured appender named "KAFKA" would fail the test with a `ClassCastException` rather than a clear assertion failure. Add an `assertInstanceOf` (or `instanceof` guard) before the cast to make failures deterministic and easier to diagnose.
##########
changes/en-us/2.x.md:
##########
@@ -30,6 +30,7 @@ Add changes here for all PR submitted to the 2.x branch.
### optimize:
+- [[#8137](https://github.com/apache/incubator-seata/pull/8137)] server modules：spring-boot upgrade to 4.0.6
Review Comment:
The English changelog entry uses a full-width colon (`：`) and the phrase "server modules" reads awkwardly in this context. Using an ASCII colon and singular "module" matches typical English changelog style.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] feature: server: spring-boot upgrade to 4.0.6 [incubator-seata]
Posted by "funky-eyes (via GitHub)" <gi...@apache.org>.
funky-eyes merged PR #8137:
URL: https://github.com/apache/incubator-seata/pull/8137
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org