You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "sabi0 (via GitHub)" <gi...@apache.org> on 2024/02/03 11:01:42 UTC
[PR] Move `brToString(BytesRef)` to `ToStringUtils` [lucene]
sabi0 opened a new pull request, #13068:
URL: https://github.com/apache/lucene/pull/13068
I noticed there are `brToString()` methods in 16 different classes.
What do you think of providing a shared implementation in the `ToStringUtils` class?
If you find the proposal useful I will proceed with removing the other copies.
Otherwise the `ToStringUtils` class could probably be deleted - the two methods there `byteArray()` and `longHex()` are not used anywhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Move `brToString(BytesRef)` to `ToStringUtils` [lucene]
Posted by "dweiss (via GitHub)" <gi...@apache.org>.
dweiss commented on code in PR #13068:
URL: https://github.com/apache/lucene/pull/13068#discussion_r1483512492
##########
lucene/core/src/java/org/apache/lucene/util/ToStringUtils.java:
##########
@@ -32,11 +32,37 @@ public static void byteArray(StringBuilder buffer, byte[] bytes) {
private static final char[] HEX = "0123456789abcdef".toCharArray();
+ /**
+ * Unlike {@link Long#toHexString(long)} returns a String with a "0x" prefix and all the leading
+ * zeros.
+ */
public static String longHex(long x) {
char[] asHex = new char[16];
for (int i = 16; --i >= 0; x >>>= 4) {
asHex[i] = HEX[(int) x & 0x0F];
}
return "0x" + new String(asHex);
}
+
+ @SuppressWarnings("unused")
+ public static String brToString(BytesRef b) {
Review Comment:
Ok. Small steps. We can always redirect and inline this method later on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Move `brToString(BytesRef)` to `ToStringUtils` [lucene]
Posted by "uschindler (via GitHub)" <gi...@apache.org>.
uschindler commented on PR #13068:
URL: https://github.com/apache/lucene/pull/13068#issuecomment-1945649280
To the other reviewers: I would like to merge this as a first step. To me this looks fine as it removes the code duplication and we have a better method name. Ok?
If we remove the static method and instead use `toString()` for that, should possibly another issue. I like the discussion started by @mikemccand and @dweiss.
I plan to merge this late afternoon German time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Move `brToString(BytesRef)` to `ToStringUtils` [lucene]
Posted by "sabi0 (via GitHub)" <gi...@apache.org>.
sabi0 commented on PR #13068:
URL: https://github.com/apache/lucene/pull/13068#issuecomment-1934260844
Thank you @cpoerschke!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Move `brToString(BytesRef)` to `ToStringUtils` [lucene]
Posted by "sabi0 (via GitHub)" <gi...@apache.org>.
sabi0 commented on code in PR #13068:
URL: https://github.com/apache/lucene/pull/13068#discussion_r1483496509
##########
lucene/core/src/java/org/apache/lucene/util/ToStringUtils.java:
##########
@@ -32,11 +32,37 @@ public static void byteArray(StringBuilder buffer, byte[] bytes) {
private static final char[] HEX = "0123456789abcdef".toCharArray();
+ /**
+ * Unlike {@link Long#toHexString(long)} returns a String with a "0x" prefix and all the leading
+ * zeros.
+ */
public static String longHex(long x) {
char[] asHex = new char[16];
for (int i = 16; --i >= 0; x >>>= 4) {
asHex[i] = HEX[(int) x & 0x0F];
}
return "0x" + new String(asHex);
}
+
+ @SuppressWarnings("unused")
+ public static String brToString(BytesRef b) {
Review Comment:
I thought of that too. But reckoned that could be too much of a change if all BytesRef's start spitting out text.
I guess the format will have to be changed somewhat to avoid the BytesRef's text "blending in" with the preceding text:
```
... previous " + bytesRef; // ... previous term [ww xx yy zz]
```
Also there is an unfortunate side-effect of an exception being thrown for "binary" data.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Move `brToString(BytesRef)` to `ToStringUtils` [lucene]
Posted by "uschindler (via GitHub)" <gi...@apache.org>.
uschindler commented on PR #13068:
URL: https://github.com/apache/lucene/pull/13068#issuecomment-1946674143
Backport was easy, no conflicts. I also checked with `fgrep -R brToString *` but no occurrences found.
Thanks @sabi0 !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Move `brToString(BytesRef)` to `ToStringUtils` [lucene]
Posted by "uschindler (via GitHub)" <gi...@apache.org>.
uschindler merged PR #13068:
URL: https://github.com/apache/lucene/pull/13068
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Move `brToString(BytesRef)` to `ToStringUtils` [lucene]
Posted by "sabi0 (via GitHub)" <gi...@apache.org>.
sabi0 commented on code in PR #13068:
URL: https://github.com/apache/lucene/pull/13068#discussion_r1483283018
##########
lucene/core/src/java/org/apache/lucene/util/ToStringUtils.java:
##########
@@ -32,11 +32,37 @@ public static void byteArray(StringBuilder buffer, byte[] bytes) {
private static final char[] HEX = "0123456789abcdef".toCharArray();
+ /**
+ * Unlike {@link Long#toHexString(long)} returns a String with a "0x" prefix and all the leading
+ * zeros.
+ */
public static String longHex(long x) {
char[] asHex = new char[16];
for (int i = 16; --i >= 0; x >>>= 4) {
asHex[i] = HEX[(int) x & 0x0F];
}
return "0x" + new String(asHex);
}
+
+ @SuppressWarnings("unused")
+ public static String brToString(BytesRef b) {
Review Comment:
I think `toString(br)` will look confusingly similar to `br.toString()`.
How about `format(br)`? Or `prettyPrint(br)` maybe?
(`bytesRefToString(br)` does look a bit long)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Move `brToString(BytesRef)` to `ToStringUtils` [lucene]
Posted by "mikemccand (via GitHub)" <gi...@apache.org>.
mikemccand commented on code in PR #13068:
URL: https://github.com/apache/lucene/pull/13068#discussion_r1483268388
##########
lucene/core/src/java/org/apache/lucene/util/ToStringUtils.java:
##########
@@ -32,11 +32,37 @@ public static void byteArray(StringBuilder buffer, byte[] bytes) {
private static final char[] HEX = "0123456789abcdef".toCharArray();
+ /**
+ * Unlike {@link Long#toHexString(long)} returns a String with a "0x" prefix and all the leading
+ * zeros.
+ */
public static String longHex(long x) {
char[] asHex = new char[16];
for (int i = 16; --i >= 0; x >>>= 4) {
asHex[i] = HEX[(int) x & 0x0F];
}
return "0x" + new String(asHex);
}
+
+ @SuppressWarnings("unused")
+ public static String brToString(BytesRef b) {
Review Comment:
Or maybe just `toString(BytesRef b)`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Move `brToString(BytesRef)` to `ToStringUtils` [lucene]
Posted by "uschindler (via GitHub)" <gi...@apache.org>.
uschindler commented on PR #13068:
URL: https://github.com/apache/lucene/pull/13068#issuecomment-1944770945
Please move entry to 9.11.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Move `brToString(BytesRef)` to `ToStringUtils` [lucene]
Posted by "mikemccand (via GitHub)" <gi...@apache.org>.
mikemccand commented on code in PR #13068:
URL: https://github.com/apache/lucene/pull/13068#discussion_r1483266841
##########
lucene/core/src/java/org/apache/lucene/util/ToStringUtils.java:
##########
@@ -32,11 +32,37 @@ public static void byteArray(StringBuilder buffer, byte[] bytes) {
private static final char[] HEX = "0123456789abcdef".toCharArray();
+ /**
+ * Unlike {@link Long#toHexString(long)} returns a String with a "0x" prefix and all the leading
+ * zeros.
+ */
public static String longHex(long x) {
char[] asHex = new char[16];
for (int i = 16; --i >= 0; x >>>= 4) {
asHex[i] = HEX[(int) x & 0x0F];
}
return "0x" + new String(asHex);
}
+
+ @SuppressWarnings("unused")
+ public static String brToString(BytesRef b) {
Review Comment:
Could we rename it to `bytesRefToString`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Move `brToString(BytesRef)` to `ToStringUtils` [lucene]
Posted by "uschindler (via GitHub)" <gi...@apache.org>.
uschindler commented on PR #13068:
URL: https://github.com/apache/lucene/pull/13068#issuecomment-1944773941
Will take care of this tomorrow. Sorry for delay.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Move `brToString(BytesRef)` to `ToStringUtils` [lucene]
Posted by "uschindler (via GitHub)" <gi...@apache.org>.
uschindler commented on code in PR #13068:
URL: https://github.com/apache/lucene/pull/13068#discussion_r1477431195
##########
lucene/core/src/java/org/apache/lucene/util/ToStringUtils.java:
##########
@@ -32,11 +32,37 @@ public static void byteArray(StringBuilder buffer, byte[] bytes) {
private static final char[] HEX = "0123456789abcdef".toCharArray();
+ /**
+ * Unlike {@link Long#toHexString(long)} returns a String with a "0x" prefix and all the leading
+ * zeros.
+ */
public static String longHex(long x) {
char[] asHex = new char[16];
for (int i = 16; --i >= 0; x >>>= 4) {
asHex[i] = HEX[(int) x & 0x0F];
}
return "0x" + new String(asHex);
}
+
+ @SuppressWarnings("unused")
+ public static String brToString(BytesRef b) {
+ if (b == null) {
+ return "null";
+ }
+ try {
+ return b.utf8ToString() + " " + b;
+ } catch (Throwable t) {
Review Comment:
This method should not catch Throwable, can we not make a multi-catch out of it and explicitely:
- `AssertionFailedError` (if we hit an Assertion)
- `RuntimeException` (anything is wrong and we have wrong offsets or bytes array is too short or incomplete surrogates
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Move `brToString(BytesRef)` to `ToStringUtils` [lucene]
Posted by "almogtavor (via GitHub)" <gi...@apache.org>.
almogtavor commented on PR #13068:
URL: https://github.com/apache/lucene/pull/13068#issuecomment-1925313927
@sabi0 i think you should also migrate these 16 classes to use the method from the `ToStringUtils`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Move `brToString(BytesRef)` to `ToStringUtils` [lucene]
Posted by "sabi0 (via GitHub)" <gi...@apache.org>.
sabi0 commented on code in PR #13068:
URL: https://github.com/apache/lucene/pull/13068#discussion_r1484475836
##########
lucene/core/src/java/org/apache/lucene/util/ToStringUtils.java:
##########
@@ -32,11 +32,37 @@ public static void byteArray(StringBuilder buffer, byte[] bytes) {
private static final char[] HEX = "0123456789abcdef".toCharArray();
+ /**
+ * Unlike {@link Long#toHexString(long)} returns a String with a "0x" prefix and all the leading
+ * zeros.
+ */
public static String longHex(long x) {
char[] asHex = new char[16];
for (int i = 16; --i >= 0; x >>>= 4) {
asHex[i] = HEX[(int) x & 0x0F];
}
return "0x" + new String(asHex);
}
+
+ @SuppressWarnings("unused")
+ public static String brToString(BytesRef b) {
Review Comment:
Shall I rename it to `bytesRefToString()` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Move `brToString(BytesRef)` to `ToStringUtils` [lucene]
Posted by "dweiss (via GitHub)" <gi...@apache.org>.
dweiss commented on code in PR #13068:
URL: https://github.com/apache/lucene/pull/13068#discussion_r1483384841
##########
lucene/core/src/java/org/apache/lucene/util/ToStringUtils.java:
##########
@@ -32,11 +32,37 @@ public static void byteArray(StringBuilder buffer, byte[] bytes) {
private static final char[] HEX = "0123456789abcdef".toCharArray();
+ /**
+ * Unlike {@link Long#toHexString(long)} returns a String with a "0x" prefix and all the leading
+ * zeros.
+ */
public static String longHex(long x) {
char[] asHex = new char[16];
for (int i = 16; --i >= 0; x >>>= 4) {
asHex[i] = HEX[(int) x & 0x0F];
}
return "0x" + new String(asHex);
}
+
+ @SuppressWarnings("unused")
+ public static String brToString(BytesRef b) {
Review Comment:
I think this method could be the default toString on BytesRef, actually... in most cases when you wish to dump it using toString it's for debugging purposes: an array of bytes would always be there, utf8 as an additional helpful hint... why add another method? Even the fact that this additional method exists points at the need to actually dump BytesRef in a more verbose way...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Move `brToString(BytesRef)` to `ToStringUtils` [lucene]
Posted by "mikemccand (via GitHub)" <gi...@apache.org>.
mikemccand commented on code in PR #13068:
URL: https://github.com/apache/lucene/pull/13068#discussion_r1483269901
##########
lucene/core/src/java/org/apache/lucene/util/ToStringUtils.java:
##########
@@ -32,11 +32,37 @@ public static void byteArray(StringBuilder buffer, byte[] bytes) {
private static final char[] HEX = "0123456789abcdef".toCharArray();
+ /**
+ * Unlike {@link Long#toHexString(long)} returns a String with a "0x" prefix and all the leading
+ * zeros.
+ */
public static String longHex(long x) {
char[] asHex = new char[16];
for (int i = 16; --i >= 0; x >>>= 4) {
asHex[i] = HEX[(int) x & 0x0F];
}
return "0x" + new String(asHex);
}
+
+ @SuppressWarnings("unused")
+ public static String brToString(BytesRef b) {
Review Comment:
Maybe also add a javadoc explaining how this differs from `BytesRef.toString`? E.g. this one does not assume valid UTF-8 but the other one days (I think)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Move `brToString(BytesRef)` to `ToStringUtils` [lucene]
Posted by "dweiss (via GitHub)" <gi...@apache.org>.
dweiss commented on code in PR #13068:
URL: https://github.com/apache/lucene/pull/13068#discussion_r1484540199
##########
lucene/core/src/java/org/apache/lucene/util/ToStringUtils.java:
##########
@@ -32,11 +32,37 @@ public static void byteArray(StringBuilder buffer, byte[] bytes) {
private static final char[] HEX = "0123456789abcdef".toCharArray();
+ /**
+ * Unlike {@link Long#toHexString(long)} returns a String with a "0x" prefix and all the leading
+ * zeros.
+ */
public static String longHex(long x) {
char[] asHex = new char[16];
for (int i = 16; --i >= 0; x >>>= 4) {
asHex[i] = HEX[(int) x & 0x0F];
}
return "0x" + new String(asHex);
}
+
+ @SuppressWarnings("unused")
+ public static String brToString(BytesRef b) {
Review Comment:
Yes, please do. Better a bit more verbose than cryptic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Move `brToString(BytesRef)` to `ToStringUtils` [lucene]
Posted by "sabi0 (via GitHub)" <gi...@apache.org>.
sabi0 commented on code in PR #13068:
URL: https://github.com/apache/lucene/pull/13068#discussion_r1477434373
##########
lucene/core/src/java/org/apache/lucene/util/ToStringUtils.java:
##########
@@ -32,11 +32,37 @@ public static void byteArray(StringBuilder buffer, byte[] bytes) {
private static final char[] HEX = "0123456789abcdef".toCharArray();
+ /**
+ * Unlike {@link Long#toHexString(long)} returns a String with a "0x" prefix and all the leading
+ * zeros.
+ */
public static String longHex(long x) {
char[] asHex = new char[16];
for (int i = 16; --i >= 0; x >>>= 4) {
asHex[i] = HEX[(int) x & 0x0F];
}
return "0x" + new String(asHex);
}
+
+ @SuppressWarnings("unused")
+ public static String brToString(BytesRef b) {
+ if (b == null) {
+ return "null";
+ }
+ try {
+ return b.utf8ToString() + " " + b;
+ } catch (Throwable t) {
Review Comment:
Nice catch. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Move `brToString(BytesRef)` to `ToStringUtils` [lucene]
Posted by "sabi0 (via GitHub)" <gi...@apache.org>.
sabi0 commented on PR #13068:
URL: https://github.com/apache/lucene/pull/13068#issuecomment-1925314365
That's what I meant with
> I will proceed with removing the other copies
Did not want to waste time on this in case the suggestion would be rejected.
I will push the changes shortly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org