[GitHub] [skywalking] CalvinKirs edited a comment on pull request #7985: [WIP]Add MicroBench module to make it easier for developers to write JMH Test

[GitBox <gi...@apache.org>]

CalvinKirs edited a comment on pull request #7985:
URL: https://github.com/apache/skywalking/pull/7985#issuecomment-950987510


   > > Moving the benchmark classes into another separate module makes me feeling super strange. Could you explain why? This module could be excluded(in default) from dist binary, and provide as `test` scope dependency for other modules.
   > > I also mentioned `server-testing`, which is providing this. Could you explain why you can't provide the basic codes into there?
   > 
   > Thank you for your review, it is still in progress, so I hope you can roughly see if it is reasonable, I understand what you mean, I will modify it, and I will tell you when I am done.
   
   I'm currently trying to do this, but I'm confused. I see that the module `server testing` is under the `oap-server` module, but JMH should be required for all backend modules, and I want to move the `server-testing` module to the top-level directory ,so that it looks more appropriate. WDYT?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org