You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Jani Averbach <ja...@jaa.iki.fi> on 2003/12/18 19:51:38 UTC
blame is failing over ra_dav (spaces in the file name)
On 2003-12-18 12:14-0700, jaa@cc.jyu.fi wrote:
The blame test is failing over ra_dav, ra_local and ra_dav are fine.
>
> BUILD: trunk r8032 on x86_64-unknown-linux-gnu shared
>
...
> At least one test FAILED, checking /data/svntest/obj-sh/tests.log
> FAIL: blame_tests.py 1: annotate a file whose name contains a space
> make: *** [check] Error 1
> Complete log saved in /data/svntest/LOG_svn_check_shared_ra_dav.8032.failed
> FAIL: make davcheck
> PASS: kill httpd-2.0
START: blame_tests.py
CMD: svnadmin "create" "local_tmp/repos" "--bdb-txn-nosync" <TIME = 3.231474>
CMD: svn "import" "--username" "jrandom" "--password" "rayjandom" "-m" "Log message for revision 1." "local_tmp/greekfiles" "http://localhost:42024/local_tmp/repos" "--config-dir" "/data/svntest/obj-sh/subversion/tests/clients/cmdline/local_tmp/config" <TIME = 5.053021>
CMD: svnadmin "create" "repositories/blame_tests-1" "--bdb-txn-nosync" <TIME = 4.955384>
CMD: svnadmin dump "local_tmp/repos" | svnadmin load "repositories/blame_tests-1" <TIME = 0.001725>
CMD: svn "co" "--username" "jrandom" "--password" "rayjandom" "http://localhost:42024/repositories/blame_tests-1" "working_copies/blame_tests-1" "--config-dir" "/data/svntest/obj-sh/subversion/tests/clients/cmdline/local_tmp/config" <TIME = 1.452800>
CMD: svn "add" "working_copies/blame_tests-1/space in name" "--config-dir" "/data/svntest/obj-sh/subversion/tests/clients/cmdline/local_tmp/config" <TIME = 0.032529>
CMD: svn "ci" "--username" "jrandom" "--password" "rayjandom" "-m" "" "working_copies/blame_tests-1/space in name" "--config-dir" "/data/svntest/obj-sh/subversion/tests/clients/cmdline/local_tmp/config" <TIME = 3.958638>
CMD: svn "blame" "working_copies/blame_tests-1/space in name" "--config-dir" "/data/svntest/obj-sh/subversion/tests/clients/cmdline/local_tmp/config" <TIME = 0.044557>
svn: Missing changed-path information for revision 2 of 'ce in name'
FAIL: blame_tests.py 1: annotate a file whose name contains a space
END: blame_tests.py
ra_local:
http://subversion.tigris.org/servlets/ReadMsg?list=svn-breakage&msgNo=6145
da_dav:
http://subversion.tigris.org/servlets/ReadMsg?list=svn-breakage&msgNo=6144
ra_svn:
http://subversion.tigris.org/servlets/ReadMsg?list=svn-breakage&msgNo=6143
Br, Jani
--
Jani Averbach
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: blame is failing over ra_dav (spaces in the file name)
Posted by John Szakmeister <jo...@szakmeister.net>.
On Thursday 18 December 2003 14:51, Jani Averbach wrote:
> On 2003-12-18 12:14-0700, jaa@cc.jyu.fi wrote:
>
> The blame test is failing over ra_dav, ra_local and ra_dav are fine.
I think you mean ra_local and ra_svn. :-) I'm checking into this.
-John
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: blame is failing over ra_dav (spaces in the file name)
Posted by John Szakmeister <jo...@szakmeister.net>.
On Thursday 18 December 2003 19:25, John Szakmeister wrote:
> Well, I tracked down this problem. Turns out we're fetching the relative
> portion of the URL in svn_ra_dav__get_repos_root(), but the relative
> portion is not URI-encoded, while ras->url is URI-encoded. What ends up
> happening is that less was shaved off of ras->url than should've been, and
> then repos_root ends up being wrong.
>
> The attached patch fixes the problem and passes both 'make check' and 'make
> davcheck'.
>
Gotta learn not to hit the send button so quickly. Here's the patch.
-John
Log:
Fixes a problem in fetching the repository root if URL contains characters
that need to be URI-encoded.
* subversion/libsvn_ra_dav/session.c
(svn_ra_dav__get_repos_root): Grab the number of bytes to truncate from a
URI-encoded version of bc_relative.
Re: blame is failing over ra_dav (spaces in the file name)
Posted by John Szakmeister <jo...@szakmeister.net>.
Well, I tracked down this problem. Turns out we're fetching the relative
portion of the URL in svn_ra_dav__get_repos_root(), but the relative portion
is not URI-encoded, while ras->url is URI-encoded. What ends up happening is
that less was shaved off of ras->url than should've been, and then repos_root
ends up being wrong.
The attached patch fixes the problem and passes both 'make check' and 'make
davcheck'.
-John
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org