You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2019/08/09 16:58:16 UTC
[GitHub] [cordova-plugin-dialogs] goffioul opened a new issue #129: Don't
specify light theme on Android
goffioul opened a new issue #129: Don't specify light theme on Android
URL: https://github.com/apache/cordova-plugin-dialogs/issues/129
The dialogs plugin on Android has the light theme hardcoded. I think the plugin shouldn't try to guess what's best, and let the app and/or the platform decide the theme the apply (usually based on the default device theme and the target SDK of the app). Is there a good reason for the dialogs plugin to assume that using the light theme unconditionally is the right way to go?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org