You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "MaxGekk (via GitHub)" <gi...@apache.org> on 2023/07/13 07:43:18 UTC

[GitHub] [spark] MaxGekk commented on a diff in pull request #41954: [SPARK-44391][SQL] Check the number of argument types in `InvokeLike`

MaxGekk commented on code in PR #41954:
URL: https://github.com/apache/spark/pull/41954#discussion_r1262151445


##########
common/utils/src/main/resources/error/error-classes.json:
##########
@@ -657,6 +657,11 @@
           "The <exprName> must be between <valueRange> (current value = <currentValue>)."
         ]
       },
+      "WRONG_NUM_ARG_TYPES" : {
+        "message" : [
+          "The expression requires <expectedNum> argument types but the actual number is <actualNum>."

Review Comment:
   If we say that the number of arguments is wrong but actually the user passes correct arguments. That might confuse much more.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org