You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafodion.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/10/19 23:34:27 UTC

[jira] [Commented] (TRAFODION-1541) Build failures or error messages when source tree is not managed in git

    [ https://issues.apache.org/jira/browse/TRAFODION-1541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14964099#comment-14964099 ] 

ASF GitHub Bot commented on TRAFODION-1541:
-------------------------------------------

GitHub user zellerh opened a pull request:

    https://github.com/apache/incubator-trafodion/pull/134

    TRAFODION-1541 Fix make errors when building outside of git

    Removed the Koraktor Maven plugin from SQL and hbasetmlib2 pom files,
    since it fails when we build a source tree that is not managed by git.
    
    Additional changes:
    
    - Added "clean" steps to remove the built jar files
    - Suppressed "svn not found" error when building outside of git
    - Added maven to traf_tools_setup.sh

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zellerh/incubator-trafodion bug/1521

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-trafodion/pull/134.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #134
    
----
commit db970e1ce6857ae4bd639fc5273395bac3d63ba0
Author: Hans Zeller <ha...@esgyn.com>
Date:   2015-10-19T21:31:32Z

    TRAFODION-1541 Fix make errors when building outside of git
    
    Removed the Koraktor Maven plugin from SQL and hbasetmlib2 pom files,
    since it fails when we build a source tree that is not managed by git.
    
    Additional changes:
    
    - Added "clean" steps to remove the built jar files
    - Suppressed "svn not found" error when building outside of git
    - Added maven to traf_tools_setup.sh

----


> Build failures or error messages when source tree is not managed in git
> -----------------------------------------------------------------------
>
>                 Key: TRAFODION-1541
>                 URL: https://issues.apache.org/jira/browse/TRAFODION-1541
>             Project: Apache Trafodion
>          Issue Type: Bug
>          Components: sql-general
>    Affects Versions: 1.2-incubating
>         Environment: Building from a downloaded source tree, without git installed
>            Reporter: Hans Zeller
>              Labels: maven
>             Fix For: 1.2-incubating
>
>
> When we recently added the Koraktor Maven plugin to generate jar file manifests, we introduced a dependency on git. When building a source tree that is not managed by git, we get the following error:
> [INFO] Building trafodion-sql 1.2.0     ##(SQL)
> [ERROR] Failed to execute goal com.github.koraktor:mavanagaiata:0.7.2:commit (git-commit) on project trafodion-sql: Unable to initialize Git repository: The GIT_DIR /home/centos/apache-trafodion-1.2.0-incubating/core/sqf/../../.git does not exist -> [Help 1]      ##(SQL)
> Other Maven projects are affected as well.
> We should either handle the absence of git in the plugin, or remove the plugin.
> While we work on this, we could also fix the error in the build-scripts/build.branch where we get an error when svn is not installed. That one does not cause the build to fail, so it is less of an issue.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)