You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@karaf.apache.org by "Geert Schuring (JIRA)" <ji...@apache.org> on 2011/03/25 23:49:06 UTC
[jira] [Created] (KARAF-535) Description for List command
incorrectly claims Threshold default is -1
Description for List command incorrectly claims Threshold default is -1
-----------------------------------------------------------------------
Key: KARAF-535
URL: https://issues.apache.org/jira/browse/KARAF-535
Project: Karaf
Issue Type: Bug
Components: console
Affects Versions: 2.2.0
Reporter: Geert Schuring
Priority: Minor
Fix For: 2.2.1
The description printed by 'help list' claims that the default value of the Threshold setting is -1, while in reality the value 50 is used.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KARAF-535) Description for List command
incorrectly claims Threshold default is -1
Posted by "Freeman Fang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13021885#comment-13021885 ]
Freeman Fang commented on KARAF-535:
------------------------------------
Hi JB,
The problem is that the "-1" in help message is auto-generated from the field default value(int bundleLevelThreshold = -1; ) in code.
This behavior is from felix gogo code base.
Regards
Freeman
> Description for List command incorrectly claims Threshold default is -1
> -----------------------------------------------------------------------
>
> Key: KARAF-535
> URL: https://issues.apache.org/jira/browse/KARAF-535
> Project: Karaf
> Issue Type: Bug
> Components: console
> Affects Versions: 2.2.0
> Reporter: Geert Schuring
> Assignee: Andreas Pieber
> Priority: Minor
> Labels: command, default, incorrect, list, shell, threshold, value
> Fix For: 2.2.1
>
> Original Estimate: 10m
> Remaining Estimate: 10m
>
> The description printed by 'help list' claims that the default value of the Threshold setting is -1, while in reality the value 50 is used.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KARAF-535) Description for List command
incorrectly claims Threshold default is -1
Posted by "Andreas Pieber (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andreas Pieber updated KARAF-535:
---------------------------------
Attachment: treshhold.idea.patch
Extended comment "correcting" default value
> Description for List command incorrectly claims Threshold default is -1
> -----------------------------------------------------------------------
>
> Key: KARAF-535
> URL: https://issues.apache.org/jira/browse/KARAF-535
> Project: Karaf
> Issue Type: Bug
> Components: console
> Affects Versions: 2.2.0
> Reporter: Geert Schuring
> Assignee: Andreas Pieber
> Priority: Minor
> Labels: command, default, incorrect, list, shell, threshold, value
> Fix For: 2.2.1
>
> Attachments: treshhold.idea.patch
>
> Original Estimate: 10m
> Remaining Estimate: 10m
>
> The description printed by 'help list' claims that the default value of the Threshold setting is -1, while in reality the value 50 is used.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KARAF-535) Description for List command
incorrectly claims Threshold default is -1
Posted by "Jean-Baptiste Onofré (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13021530#comment-13021530 ]
Jean-Baptiste Onofré commented on KARAF-535:
--------------------------------------------
Not sure that Felix will accept this kind of patch :)
It's clear that it's better to have the threshold level defined in the custom.properties file to let users set the value for their needs.
If the issue is in the help, maybe first a change in the help message (to avoid to confuse people) is enough.
> Description for List command incorrectly claims Threshold default is -1
> -----------------------------------------------------------------------
>
> Key: KARAF-535
> URL: https://issues.apache.org/jira/browse/KARAF-535
> Project: Karaf
> Issue Type: Bug
> Components: console
> Affects Versions: 2.2.0
> Reporter: Geert Schuring
> Assignee: Andreas Pieber
> Priority: Minor
> Labels: command, default, incorrect, list, shell, threshold, value
> Fix For: 2.2.1
>
> Original Estimate: 10m
> Remaining Estimate: 10m
>
> The description printed by 'help list' claims that the default value of the Threshold setting is -1, while in reality the value 50 is used.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KARAF-535) Description for List command
incorrectly claims Threshold default is -1
Posted by "Andreas Pieber (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13025696#comment-13025696 ]
Andreas Pieber commented on KARAF-535:
--------------------------------------
Well, "Defaults to " is written to console --> I took this as name :); +1 to allow specifying a default value for docs. I can add this functionality tomorrow if the idea is accepted.
> Description for List command incorrectly claims Threshold default is -1
> -----------------------------------------------------------------------
>
> Key: KARAF-535
> URL: https://issues.apache.org/jira/browse/KARAF-535
> Project: Karaf
> Issue Type: Bug
> Components: console
> Affects Versions: 2.2.0
> Reporter: Geert Schuring
> Assignee: Andreas Pieber
> Priority: Minor
> Labels: command, default, incorrect, list, shell, threshold, value
> Fix For: 2.2.1
>
> Attachments: printDefaults.patch, treshhold.idea.patch
>
> Original Estimate: 10m
> Remaining Estimate: 10m
>
> The description printed by 'help list' claims that the default value of the Threshold setting is -1, while in reality the value 50 is used.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KARAF-535) Description for List command
incorrectly claims Threshold default is -1
Posted by "Andreas Pieber (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13023503#comment-13023503 ]
Andreas Pieber commented on KARAF-535:
--------------------------------------
OK, since we do not want/cant correct this behavior in felix gogo I've simply stepped ahead and changed the comment. I think this is not perfect (that's the reason I'm not commiting straight ahead), but following this thread and it's discussion I think it's the best we can do (and I really want to close this issue and get 2.2.1 out ;) ). WDYT?
> Description for List command incorrectly claims Threshold default is -1
> -----------------------------------------------------------------------
>
> Key: KARAF-535
> URL: https://issues.apache.org/jira/browse/KARAF-535
> Project: Karaf
> Issue Type: Bug
> Components: console
> Affects Versions: 2.2.0
> Reporter: Geert Schuring
> Assignee: Andreas Pieber
> Priority: Minor
> Labels: command, default, incorrect, list, shell, threshold, value
> Fix For: 2.2.1
>
> Attachments: treshhold.idea.patch
>
> Original Estimate: 10m
> Remaining Estimate: 10m
>
> The description printed by 'help list' claims that the default value of the Threshold setting is -1, while in reality the value 50 is used.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KARAF-535) Description for List command
incorrectly claims Threshold default is -1
Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13025671#comment-13025671 ]
Guillaume Nodet commented on KARAF-535:
---------------------------------------
What does the "to" mean in printDefaultsTo ? Just wondering if printDefault would be better, or even maybe if a "default" value as a string would enable overriding or specifying a different value for doc.
> Description for List command incorrectly claims Threshold default is -1
> -----------------------------------------------------------------------
>
> Key: KARAF-535
> URL: https://issues.apache.org/jira/browse/KARAF-535
> Project: Karaf
> Issue Type: Bug
> Components: console
> Affects Versions: 2.2.0
> Reporter: Geert Schuring
> Assignee: Andreas Pieber
> Priority: Minor
> Labels: command, default, incorrect, list, shell, threshold, value
> Fix For: 2.2.1
>
> Attachments: printDefaults.patch, treshhold.idea.patch
>
> Original Estimate: 10m
> Remaining Estimate: 10m
>
> The description printed by 'help list' claims that the default value of the Threshold setting is -1, while in reality the value 50 is used.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KARAF-535) Description for List command
incorrectly claims Threshold default is -1
Posted by "Andreas Pieber (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13021988#comment-13021988 ]
Andreas Pieber commented on KARAF-535:
--------------------------------------
yep, that was what I've mend by providing a patch to felix; adding an option to not including the "default-value" into the print. But though, maybe we can simply add a comment that the default value shown here could be safely ignored and instead the one in xxx is valid...
> Description for List command incorrectly claims Threshold default is -1
> -----------------------------------------------------------------------
>
> Key: KARAF-535
> URL: https://issues.apache.org/jira/browse/KARAF-535
> Project: Karaf
> Issue Type: Bug
> Components: console
> Affects Versions: 2.2.0
> Reporter: Geert Schuring
> Assignee: Andreas Pieber
> Priority: Minor
> Labels: command, default, incorrect, list, shell, threshold, value
> Fix For: 2.2.1
>
> Original Estimate: 10m
> Remaining Estimate: 10m
>
> The description printed by 'help list' claims that the default value of the Threshold setting is -1, while in reality the value 50 is used.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KARAF-535) Description for List command
incorrectly claims Threshold default is -1
Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13023509#comment-13023509 ]
Guillaume Nodet commented on KARAF-535:
---------------------------------------
Note that the annotations are not defined in Felix anymore, they are in:
http://svn.apache.org/repos/asf/karaf/trunk/shell/console/src/main/java/org/apache/felix/gogo/commands/
> Description for List command incorrectly claims Threshold default is -1
> -----------------------------------------------------------------------
>
> Key: KARAF-535
> URL: https://issues.apache.org/jira/browse/KARAF-535
> Project: Karaf
> Issue Type: Bug
> Components: console
> Affects Versions: 2.2.0
> Reporter: Geert Schuring
> Assignee: Andreas Pieber
> Priority: Minor
> Labels: command, default, incorrect, list, shell, threshold, value
> Fix For: 2.2.1
>
> Attachments: treshhold.idea.patch
>
> Original Estimate: 10m
> Remaining Estimate: 10m
>
> The description printed by 'help list' claims that the default value of the Threshold setting is -1, while in reality the value 50 is used.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KARAF-535) Description for List command
incorrectly claims Threshold default is -1
Posted by "Andreas Pieber (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13018215#comment-13018215 ]
Andreas Pieber commented on KARAF-535:
--------------------------------------
I've experienced now a little bit with this solution, but I'm still not too happy with it since -1 IS the default level... I've thought about another option; a patch to felix which includes a new field into org.apache.felix.gogo.commands.Option (show defaults which defaults to true) and then in org.apache.felix.gogo.commands.basic.DefaultActionPreparator#printUsage if (!argument.required() && argument.displayDefaults()) {.
Do you think felix will accept such a patch?
> Description for List command incorrectly claims Threshold default is -1
> -----------------------------------------------------------------------
>
> Key: KARAF-535
> URL: https://issues.apache.org/jira/browse/KARAF-535
> Project: Karaf
> Issue Type: Bug
> Components: console
> Affects Versions: 2.2.0
> Reporter: Geert Schuring
> Assignee: Andreas Pieber
> Priority: Minor
> Labels: command, default, incorrect, list, shell, threshold, value
> Fix For: 2.2.1
>
> Original Estimate: 10m
> Remaining Estimate: 10m
>
> The description printed by 'help list' claims that the default value of the Threshold setting is -1, while in reality the value 50 is used.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KARAF-535) Description for List command
incorrectly claims Threshold default is -1
Posted by "Andreas Pieber (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andreas Pieber updated KARAF-535:
---------------------------------
Attachment: printDefaults.patch
OK another option now (that I've found out that we manage those commands ourselves :) If you think this is a good solution I'll create a separate issue for this improvement
> Description for List command incorrectly claims Threshold default is -1
> -----------------------------------------------------------------------
>
> Key: KARAF-535
> URL: https://issues.apache.org/jira/browse/KARAF-535
> Project: Karaf
> Issue Type: Bug
> Components: console
> Affects Versions: 2.2.0
> Reporter: Geert Schuring
> Assignee: Andreas Pieber
> Priority: Minor
> Labels: command, default, incorrect, list, shell, threshold, value
> Fix For: 2.2.1
>
> Attachments: printDefaults.patch, treshhold.idea.patch
>
> Original Estimate: 10m
> Remaining Estimate: 10m
>
> The description printed by 'help list' claims that the default value of the Threshold setting is -1, while in reality the value 50 is used.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KARAF-535) Description for List command
incorrectly claims Threshold default is -1
Posted by "Achim Nierbeck (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13017900#comment-13017900 ]
Achim Nierbeck commented on KARAF-535:
--------------------------------------
We should leave it in the custom.properties, because this way everybody can change it to the way it fits his needs. If it is hardcoded in the sources a fragment or something else is needed.
> Description for List command incorrectly claims Threshold default is -1
> -----------------------------------------------------------------------
>
> Key: KARAF-535
> URL: https://issues.apache.org/jira/browse/KARAF-535
> Project: Karaf
> Issue Type: Bug
> Components: console
> Affects Versions: 2.2.0
> Reporter: Geert Schuring
> Assignee: Andreas Pieber
> Priority: Minor
> Labels: command, default, incorrect, list, shell, threshold, value
> Fix For: 2.2.1
>
> Original Estimate: 10m
> Remaining Estimate: 10m
>
> The description printed by 'help list' claims that the default value of the Threshold setting is -1, while in reality the value 50 is used.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Work started] (KARAF-535) Description for List command
incorrectly claims Threshold default is -1
Posted by "Andreas Pieber (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Work on KARAF-535 started by Andreas Pieber.
> Description for List command incorrectly claims Threshold default is -1
> -----------------------------------------------------------------------
>
> Key: KARAF-535
> URL: https://issues.apache.org/jira/browse/KARAF-535
> Project: Karaf
> Issue Type: Bug
> Components: console
> Affects Versions: 2.2.0
> Reporter: Geert Schuring
> Assignee: Andreas Pieber
> Priority: Minor
> Labels: command, default, incorrect, list, shell, threshold, value
> Fix For: 2.2.1
>
> Attachments: printDefaults.patch, treshhold.idea.patch
>
> Original Estimate: 10m
> Remaining Estimate: 10m
>
> The description printed by 'help list' claims that the default value of the Threshold setting is -1, while in reality the value 50 is used.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KARAF-535) Description for List command
incorrectly claims Threshold default is -1
Posted by "Andreas Pieber (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13017817#comment-13017817 ]
Andreas Pieber commented on KARAF-535:
--------------------------------------
ooook, the problem is that the definition is
int bundleLevelThreshold = -1;
which is overwritten by the custom.properties file to 50. We have two options here: either set the bundleLevelTreshhold in org.apache.karaf.shell.osgi.ListBundles to 50 or/an remove the configuration in custom.properties. I think setting the variable in ListBundles to 50 and removing it completely from the custom.properties is the better way. @Guillaume & JB: WDYT?
> Description for List command incorrectly claims Threshold default is -1
> -----------------------------------------------------------------------
>
> Key: KARAF-535
> URL: https://issues.apache.org/jira/browse/KARAF-535
> Project: Karaf
> Issue Type: Bug
> Components: console
> Affects Versions: 2.2.0
> Reporter: Geert Schuring
> Priority: Minor
> Labels: command, default, incorrect, list, shell, threshold, value
> Fix For: 2.2.1
>
> Original Estimate: 10m
> Remaining Estimate: 10m
>
> The description printed by 'help list' claims that the default value of the Threshold setting is -1, while in reality the value 50 is used.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KARAF-535) Description for List command
incorrectly claims Threshold default is -1
Posted by "Andreas Pieber (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13017883#comment-13017883 ]
Andreas Pieber commented on KARAF-535:
--------------------------------------
thinking a little bit further about this issue and looking deeper into the code I have to admit that I rather like the current approach of having the default to -1 and having a "pseudo-default" at 50 in custom.properties. I think we should simply set the -1 value in the constructor instead of during the declaration (to avoid the defaults to in the help list command). WDYT?
> Description for List command incorrectly claims Threshold default is -1
> -----------------------------------------------------------------------
>
> Key: KARAF-535
> URL: https://issues.apache.org/jira/browse/KARAF-535
> Project: Karaf
> Issue Type: Bug
> Components: console
> Affects Versions: 2.2.0
> Reporter: Geert Schuring
> Assignee: Andreas Pieber
> Priority: Minor
> Labels: command, default, incorrect, list, shell, threshold, value
> Fix For: 2.2.1
>
> Original Estimate: 10m
> Remaining Estimate: 10m
>
> The description printed by 'help list' claims that the default value of the Threshold setting is -1, while in reality the value 50 is used.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (KARAF-535) Description for List command
incorrectly claims Threshold default is -1
Posted by "Andreas Pieber (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andreas Pieber closed KARAF-535.
--------------------------------
Resolution: Fixed
Fix Version/s: 3.0.0
Committing to https://svn.apache.org/repos/asf/karaf/branches/karaf-2.2.x ...
M shell/osgi/src/main/java/org/apache/karaf/shell/osgi/ListBundles.java
Committed r1098161
Committing to https://svn.apache.org/repos/asf/karaf/trunk ...
M shell/osgi/src/main/java/org/apache/karaf/shell/osgi/ListBundles.java
Committed r1098167
> Description for List command incorrectly claims Threshold default is -1
> -----------------------------------------------------------------------
>
> Key: KARAF-535
> URL: https://issues.apache.org/jira/browse/KARAF-535
> Project: Karaf
> Issue Type: Bug
> Components: console
> Affects Versions: 2.2.0
> Reporter: Geert Schuring
> Assignee: Andreas Pieber
> Priority: Minor
> Labels: command, default, incorrect, list, shell, threshold, value
> Fix For: 2.2.1, 3.0.0
>
> Attachments: printDefaults.patch, treshhold.idea.patch
>
> Original Estimate: 10m
> Remaining Estimate: 10m
>
> The description printed by 'help list' claims that the default value of the Threshold setting is -1, while in reality the value 50 is used.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (KARAF-535) Description for List command
incorrectly claims Threshold default is -1
Posted by "Andreas Pieber (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andreas Pieber reassigned KARAF-535:
------------------------------------
Assignee: Andreas Pieber
> Description for List command incorrectly claims Threshold default is -1
> -----------------------------------------------------------------------
>
> Key: KARAF-535
> URL: https://issues.apache.org/jira/browse/KARAF-535
> Project: Karaf
> Issue Type: Bug
> Components: console
> Affects Versions: 2.2.0
> Reporter: Geert Schuring
> Assignee: Andreas Pieber
> Priority: Minor
> Labels: command, default, incorrect, list, shell, threshold, value
> Fix For: 2.2.1
>
> Original Estimate: 10m
> Remaining Estimate: 10m
>
> The description printed by 'help list' claims that the default value of the Threshold setting is -1, while in reality the value 50 is used.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KARAF-535) Description for List command
incorrectly claims Threshold default is -1
Posted by "Jean-Baptiste Onofré (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13023508#comment-13023508 ]
Jean-Baptiste Onofré commented on KARAF-535:
--------------------------------------------
As this issue is also present into Karaf 2.2.0, I propose to work on it on trunk (with Felix team) and let as it is for Karaf 2.2.1 (consistent with Karaf 2.2.0 :)).
> Description for List command incorrectly claims Threshold default is -1
> -----------------------------------------------------------------------
>
> Key: KARAF-535
> URL: https://issues.apache.org/jira/browse/KARAF-535
> Project: Karaf
> Issue Type: Bug
> Components: console
> Affects Versions: 2.2.0
> Reporter: Geert Schuring
> Assignee: Andreas Pieber
> Priority: Minor
> Labels: command, default, incorrect, list, shell, threshold, value
> Fix For: 2.2.1
>
> Attachments: treshhold.idea.patch
>
> Original Estimate: 10m
> Remaining Estimate: 10m
>
> The description printed by 'help list' claims that the default value of the Threshold setting is -1, while in reality the value 50 is used.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira