You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "tmgodinho (via GitHub)" <gi...@apache.org> on 2025/12/15 22:57:02 UTC
[PR] IGNITE-27361 Reintroduce check for POJOs without default constructors in MapperBuilder [ignite-3]
tmgodinho opened a new pull request, #7240:
URL: https://github.com/apache/ignite-3/pull/7240
https://issues.apache.org/jira/browse/IGNITE-27361
* Reintroduce check for default constructor in MapperBuilder#ensureValidPojo
** Extract methods from Creator into a new RecordSupport utility class.
* Improve RecordSupport#isRecord API not to throw so many exceptions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-27361 Reintroduce check for POJOs without default constructors in MapperBuilder [ignite-3]
Posted by "ptupitsyn (via GitHub)" <gi...@apache.org>.
ptupitsyn merged PR #7240:
URL: https://github.com/apache/ignite-3/pull/7240
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-27361 Reintroduce check for POJOs without default constructors in MapperBuilder [ignite-3]
Posted by "tmgodinho (via GitHub)" <gi...@apache.org>.
tmgodinho commented on PR #7240:
URL: https://github.com/apache/ignite-3/pull/7240#issuecomment-3669945366
If this is approved, I'll also update the test in the marshallers module to use RecordSupportInternal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-27361 Reintroduce check for POJOs without default constructors in MapperBuilder [ignite-3]
Posted by "tmgodinho (via GitHub)" <gi...@apache.org>.
tmgodinho commented on PR #7240:
URL: https://github.com/apache/ignite-3/pull/7240#issuecomment-3669846784
Hi @ptupitsyn, could you check if this is what you had in mind??
The RecordSupport class in the API is now a package-private.
In the Marshallers module, introduced a new RecordSupportInternal with the necessary methods. This package is in `` to access the RecordSupport package private methods. We could also do this using method handles and keep everything in the same package as before.
Also added two tests one to the API the other in the marshallers module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-27361 Reintroduce check for POJOs without default constructors in MapperBuilder [ignite-3]
Posted by "ptupitsyn (via GitHub)" <gi...@apache.org>.
ptupitsyn commented on code in PR #7240:
URL: https://github.com/apache/ignite-3/pull/7240#discussion_r2626182104
##########
modules/api/src/main/java/org/apache/ignite/lang/RecordSupport.java:
##########
@@ -0,0 +1,100 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.lang;
+
+import java.lang.reflect.Constructor;
+import java.lang.reflect.InvocationTargetException;
+import java.lang.reflect.Method;
+
+/** Provides utility methods to support records in Java 11. */
+public class RecordSupport {
Review Comment:
I don't think this should be a part of the public API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org