You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Ramesh Mani <rm...@hortonworks.com> on 2018/02/15 19:06:22 UTC

Review Request 65677: ATLAS-2450 : HBase Atlas Hook: Wrong creating time of NameSpace if they are create before enabling HBase hook

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65677/
-----------------------------------------------------------

Review request for atlas and Madhan Neethiraj.


Bugs: ATLAS-2450
    https://issues.apache.org/jira/browse/ATLAS-2450


Repository: atlas


Description
-------

ATLAS-2450 : HBase Atlas Hook: Wrong creating time of NameSpace if they are create before enabling HBase hook


Diffs
-----

  addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/HBaseAtlasHook.java 2074684 


Diff: https://reviews.apache.org/r/65677/diff/1/


Testing
-------

Tested in local vm


Thanks,

Ramesh Mani


Re: Review Request 65677: ATLAS-2450 : HBase Atlas Hook: Wrong creating time of NameSpace if they are create before enabling HBase hook

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65677/#review197640
-----------------------------------------------------------




addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/HBaseAtlasHook.java
Lines 429 (patched)
<https://reviews.apache.org/r/65677/#comment277861>

    Wouldn't this reset createTime of namespaces when tables are created in the namespace?
    
    NameSpaceDescriptor doesn't provide create/update time stamps. So, Atlas hook will not be able to populate these fields for namespaces that were created before Atlas hook was enabled. https://hbase.apache.org/apidocs/org/apache/hadoop/hbase/NamespaceDescriptor.html


- Madhan Neethiraj


On Feb. 15, 2018, 7:06 p.m., Ramesh Mani wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65677/
> -----------------------------------------------------------
> 
> (Updated Feb. 15, 2018, 7:06 p.m.)
> 
> 
> Review request for atlas and Madhan Neethiraj.
> 
> 
> Bugs: ATLAS-2450
>     https://issues.apache.org/jira/browse/ATLAS-2450
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> ATLAS-2450 : HBase Atlas Hook: Wrong creating time of NameSpace if they are create before enabling HBase hook
> 
> 
> Diffs
> -----
> 
>   addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/HBaseAtlasHook.java 2074684 
> 
> 
> Diff: https://reviews.apache.org/r/65677/diff/1/
> 
> 
> Testing
> -------
> 
> Tested in local vm
> 
> 
> Thanks,
> 
> Ramesh Mani
> 
>