You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "eirikbakke (via GitHub)" <gi...@apache.org> on 2023/01/20 23:00:40 UTC
[GitHub] [netbeans] eirikbakke opened a new pull request, #5338: Copy FlatLAF label positioning improvements into the Windows LAF
eirikbakke opened a new pull request, #5338:
URL: https://github.com/apache/netbeans/pull/5338
This PR copies the previously merged [text alignment improvements](https://github.com/apache/netbeans/pull/4349) in FlatLAF window system tabs back to the older Windows LAF.
This completes the tab component saga originally started in https://github.com/apache/netbeans/pull/3115 ; this PR corresponds to the last commit of the latter.
At some point we might want to move the FlatLAF tab control implementations into o.n.swing.tabcontrol so the code can be shared, but they have some dependencies on FlatLAF-specific UI scaling utilities and so on. But the Windows LAF will probably be obsoleted by FlatLAF soon anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on pull request #5338: Copy FlatLAF label positioning improvements into the Windows LAF
Posted by "eirikbakke (via GitHub)" <gi...@apache.org>.
eirikbakke commented on PR #5338:
URL: https://github.com/apache/netbeans/pull/5338#issuecomment-1573903330
I'll apply this PR in a few weeks if nobody objects. It's some leftover improvements to the now rather outdated Windows LAF.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #5338: Copy FlatLAF label positioning improvements into the Windows LAF
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on PR #5338:
URL: https://github.com/apache/netbeans/pull/5338#issuecomment-1573923468
Sounds good. I don't really use Windows, so possibly not the best person to review. Maybe you could add a before / after screenshot?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke merged pull request #5338: Copy FlatLAF label positioning improvements into the Windows LAF
Posted by "eirikbakke (via GitHub)" <gi...@apache.org>.
eirikbakke merged PR #5338:
URL: https://github.com/apache/netbeans/pull/5338
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on pull request #5338: Copy FlatLAF label positioning improvements into the Windows LAF
Posted by "eirikbakke (via GitHub)" <gi...@apache.org>.
eirikbakke commented on PR #5338:
URL: https://github.com/apache/netbeans/pull/5338#issuecomment-1685063859
I did some before/after comparisons on the Windows LAF and decided a one-pixel adjustment in a LAF-specific Y offset was needed ("+ 1" instead of "+ 2" in WinFlatViewTabDisplayerUI and similarly "1 +" instead of "2 +" in WinFlatEditorTabCellRenderer).
After this change, the tabs in fact look identical before and after this PR... (tested on 100% HiDPI scaling, on 150% HiDPI scaling, and with "--fontsize 20" on 100% HiDPI scaling)
So the only benefit of this PR is harmonizing the copy/pasted between FlatLAF tabs and the old Windows LAF.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists