You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/07/13 04:05:22 UTC

[GitHub] [pulsar] michaeljmarshall commented on a diff in pull request #16342: [proxy] Do not preserve host when forwarding admin requests.

michaeljmarshall commented on code in PR #16342:
URL: https://github.com/apache/pulsar/pull/16342#discussion_r919625294


##########
pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyServiceStarter.java:
##########
@@ -267,7 +267,6 @@ public static void addWebServerHandlers(WebServer server,
 
         AdminProxyHandler adminProxyHandler = new AdminProxyHandler(config, discoveryProvider);
         ServletHolder servletHolder = new ServletHolder(adminProxyHandler);
-        servletHolder.setInitParameter("preserveHost", "true");

Review Comment:
   I noticed that there are several other locations where this is set in tests. @fantapsody, would you be able to remove those settings as well?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org