You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Hao Hao (Code Review)" <ge...@cloudera.org> on 2019/08/14 19:20:22 UTC
[Impala-ASF-CR] IMPALA-8856: Deflake TestKuduHMSIntegration
Hao Hao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14067
Change subject: IMPALA-8856: Deflake TestKuduHMSIntegration
......................................................................
IMPALA-8856: Deflake TestKuduHMSIntegration
Tests for Kudu's integration with the Hive Metastore can be flaky.
Since Kudu depends on the HMS, create/drop table requests can timeout
when creation/deletion in the HMS take more than 10s, and the following
retry will fail as the table has been already created/deleted by the
first request.
This patch increases the timeout of individual Kudu client rpcs to
avoid flakiness cause by such cases.
Change-Id: Ib98f34bb831b9255e35b5ef234abe6ceaf261bfd
---
M tests/custom_cluster/test_kudu.py
1 file changed, 19 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/67/14067/1
--
To view, visit http://gerrit.cloudera.org:8080/14067
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib98f34bb831b9255e35b5ef234abe6ceaf261bfd
Gerrit-Change-Number: 14067
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
[Impala-ASF-CR] IMPALA-8856: Deflake TestKuduHMSIntegration
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14067 )
Change subject: IMPALA-8856: Deflake TestKuduHMSIntegration
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4791/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/14067
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib98f34bb831b9255e35b5ef234abe6ceaf261bfd
Gerrit-Change-Number: 14067
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 14 Aug 2019 20:28:31 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8856: Deflake TestKuduHMSIntegration
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14067 )
Change subject: IMPALA-8856: Deflake TestKuduHMSIntegration
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14067
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib98f34bb831b9255e35b5ef234abe6ceaf261bfd
Gerrit-Change-Number: 14067
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 14 Aug 2019 22:14:11 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8856: Deflake TestKuduHMSIntegration
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14067 )
Change subject: IMPALA-8856: Deflake TestKuduHMSIntegration
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/4251/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14067
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib98f34bb831b9255e35b5ef234abe6ceaf261bfd
Gerrit-Change-Number: 14067
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 14 Aug 2019 20:03:41 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8856: Deflake TestKuduHMSIntegration
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14067 )
Change subject: IMPALA-8856: Deflake TestKuduHMSIntegration
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/14067
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib98f34bb831b9255e35b5ef234abe6ceaf261bfd
Gerrit-Change-Number: 14067
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 15 Aug 2019 00:35:48 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8856: Deflake TestKuduHMSIntegration
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14067 )
Change subject: IMPALA-8856: Deflake TestKuduHMSIntegration
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4793/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/14067
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib98f34bb831b9255e35b5ef234abe6ceaf261bfd
Gerrit-Change-Number: 14067
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 14 Aug 2019 22:14:22 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8856: Deflake TestKuduHMSIntegration
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14067 )
Change subject: IMPALA-8856: Deflake TestKuduHMSIntegration
......................................................................
IMPALA-8856: Deflake TestKuduHMSIntegration
Tests for Kudu's integration with the Hive Metastore can be flaky.
Since Kudu depends on the HMS, create/drop table requests can timeout
when creation/deletion in the HMS take more than 10s, and the following
retry will fail as the table has been already created/deleted by the
first request.
This patch increases the timeout of individual Kudu client rpcs to
avoid flakiness cause by such cases.
Change-Id: Ib98f34bb831b9255e35b5ef234abe6ceaf261bfd
Reviewed-on: http://gerrit.cloudera.org:8080/14067
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/custom_cluster/test_kudu.py
1 file changed, 19 insertions(+), 5 deletions(-)
Approvals:
Tim Armstrong: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/14067
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib98f34bb831b9255e35b5ef234abe6ceaf261bfd
Gerrit-Change-Number: 14067
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>