You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "benwtrent (via GitHub)" <gi...@apache.org> on 2023/08/26 14:51:21 UTC
[GitHub] [lucene] benwtrent opened a new pull request, #12518: Use panama vector for l2normalize
benwtrent opened a new pull request, #12518:
URL: https://github.com/apache/lucene/pull/12518
Seems like a minor oversight, but we should use panama vector for l2normlize.
While this code isn't really used in hot-paths, it is a public API I could easily see folks using before indexing vectors into Lucene.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] ChrisHegarty commented on pull request #12518: Use panama vector for l2normalize
Posted by "ChrisHegarty (via GitHub)" <gi...@apache.org>.
ChrisHegarty commented on PR #12518:
URL: https://github.com/apache/lucene/pull/12518#issuecomment-1695885121
> How about we add a test scenario to `TestVectorUtilSupport`.
Ignore. I thought that the method was at a different level in the hierarchy. My comment doesn't make sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] benwtrent merged pull request #12518: Use panama vector for l2normalize
Posted by "benwtrent (via GitHub)" <gi...@apache.org>.
benwtrent merged PR #12518:
URL: https://github.com/apache/lucene/pull/12518
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] uschindler commented on pull request #12518: Use panama vector for l2normalize
Posted by "uschindler (via GitHub)" <gi...@apache.org>.
uschindler commented on PR #12518:
URL: https://github.com/apache/lucene/pull/12518#issuecomment-1704979491
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] ChrisHegarty commented on pull request #12518: Use panama vector for l2normalize
Posted by "ChrisHegarty (via GitHub)" <gi...@apache.org>.
ChrisHegarty commented on PR #12518:
URL: https://github.com/apache/lucene/pull/12518#issuecomment-1695880133
How about we add a test scenario to `TestVectorUtilSupport`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org