[jira] [Commented] (HIVE-9835) [CBO] Add a rule to insert exchange operator in front of group by in calcite tree

["Jesus Camacho Rodriguez (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-9835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14347060#comment-14347060 ] 

Jesus Camacho Rodriguez commented on HIVE-9835:
-----------------------------------------------

[~ashutoshc], here are my comments.
1) As the result of the rule is Aggregate-Exchange-Aggregate, I'm afraid that the condition at the beginning of the {{onMatch}} method is not enough to avoid that the rule applies indefinitely (the rule would apply on the Aggregate below again?). What do you think?
2) It seems to me that the following block replaces the Aggregate underneath by a similar aggregate? Is this necessary?
{noformat}
if(mapAggr) {
  Aggregate mapGby = gby.copy(gby.getTraitSet(), ex.getInput(), gby.indicator, gby.getGroupSet(), gby.getGroupSets(),  gby.getAggCallList());
  call.getPlanner().onCopy(gby, mapGby);
  call.transformTo(mapGby);
}
{noformat}


> [CBO] Add a rule to insert exchange operator in front of group by in calcite tree
> ---------------------------------------------------------------------------------
>
>                 Key: HIVE-9835
>                 URL: https://issues.apache.org/jira/browse/HIVE-9835
>             Project: Hive
>          Issue Type: Task
>          Components: CBO
>    Affects Versions: cbo-branch
>            Reporter: Ashutosh Chauhan
>            Assignee: Ashutosh Chauhan
>         Attachments: HIVE-9835.cbo.patch
>
>
> Takes into account map side aggregation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)