You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/02/12 12:22:36 UTC

[GitHub] [camel] davsclaus commented on a change in pull request #5078: CAMEL-16190 Sensitive configuration values not redacted in Auto-confi…

davsclaus commented on a change in pull request #5078:
URL: https://github.com/apache/camel/pull/5078#discussion_r575185873



##########
File path: core/camel-util/src/main/java/org/apache/camel/util/SensitiveUtils.java
##########
@@ -95,6 +95,10 @@ private SensitiveUtils() {
     }
 
     public static boolean containsSensitive(String text) {
+        int lastPeriod = text.lastIndexOf('.');
+        if (lastPeriod >= 0) {
+            text = text.substring(lastPeriod + 1);

Review comment:
       Ah nice catch. Just a note that if the text ends with a dot, then you get a out of bounds exception.
   Though it doesnt make sense to have keys that ends with a dot, but maybe an user make a typo




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org