You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "SBIN2010 (via GitHub)" <gi...@apache.org> on 2024/09/18 20:05:41 UTC
[I] legacy-plugin-chart-country-map on the map of Russia Karelia is located on the territory of the Murmansk region [superset]
SBIN2010 opened a new issue, #30326:
URL: https://github.com/apache/superset/issues/30326
### Bug description
Karelia is not displayed correctly on the map of Russia. It should be located separately, and not as part of Murmansk
### How to reproduce the bug
Open legacy-plugin-chart-country-map map of Russia
### Screenshots/recordings
To 
after

### Superset version
4.0.2
### Python version
3.9
### Node version
16
### Browser
Chrome
### Additional context
_No response_
### Checklist
- [X] I have searched Superset docs and Slack and didn't find a solution to my problem.
- [X] I have searched the GitHub issue tracker and didn't find a similar bug report.
- [X] I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] legacy-plugin-chart-country-map on the map of Russia Karelia is located on the territory of the Murmansk region [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #30326:
URL: https://github.com/apache/superset/issues/30326#issuecomment-2368921753
If you're able/willing to open a PR to correct this, the right way to do so would be to make a correction in the Jypyter Notebook (the repo's one `.ipynb` file) and have THAT render out the geoJSON. Otherwise, any GeoJSON overrides will eventually be overwritten in the future. Also, the files we get are generated from NaturalEarth data... you may want to ping them on their repo about correcting it at the root. We're downstream, and just patch things with overrides as much as we're able to.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] legacy-plugin-chart-country-map on the map of Russia Karelia is located on the territory of the Murmansk region [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #30326:
URL: https://github.com/apache/superset/issues/30326#issuecomment-5706173580
#44273 looks like it finally fixes this the right way, correcting the boundary through the notebook generator instead of hand-patching the GeoJSON. CI's green, just needs review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] legacy-plugin-chart-country-map on the map of Russia Karelia is located on the territory of the Murmansk region [superset]
Posted by "dosubot[bot] (via GitHub)" <gi...@apache.org>.
dosubot[bot] commented on issue #30326:
URL: https://github.com/apache/superset/issues/30326#issuecomment-2368925660
<!-- Answer -->
To correctly display Karelia separately from the Murmansk region on the legacy-plugin-chart-country-map for Russia in Superset version 4.0.2, you need to ensure that the GeoJSON data for both Karelia and the Murmansk region are correctly defined and distinct in the `russia.geojson` file.
Here is the correct GeoJSON data for Karelia:
```geojson
{
"type": "Feature",
"properties": { "ISO": "RU-KR", "NAME_1": "Karelia" },
"geometry": {
"type": "Polygon",
"coordinates": [
[
[35.8583984375, 65.077929687500003],
[35.827343750000011, 65.036474609375006],
[35.84228515625, 65.00146484375],
[35.778710937500023, 64.976660156250006],
[35.680078125000023, 65.0576171875],
[35.621386718750017, 65.058789062499997],
[35.55859375, 65.093603515625006],
[35.52890625, 65.151074218749997],
[35.585742187500017, 65.167089843750006],
[35.608691406250017, 65.157128906249994],
[35.729101562500006, 65.197558593750003],
[35.816113281250011, 65.182080078124997],
[35.848437500000017, 65.142675781250006],
[35.8583984375, 65.077929687500003]
]
]
}
}
```
And here is an example of how you might define the Murmansk region:
```geojson
{
"type": "Feature",
"properties": { "ISO": "RU-MUR", "NAME_1": "Murmansk" },
"geometry": {
"type": "Polygon",
"coordinates": [
[
[32.0, 69.0],
[33.0, 69.0],
[33.0, 68.0],
[32.0, 68.0],
[32.0, 69.0]
]
]
}
}
```
Ensure both regions are included in the `russia.geojson` file. This will ensure that Karelia and the Murmansk region are displayed separately on the map <sup>[[1]](https://github.com/apache/superset/blob/master/superset-frontend/plugins/legacy-plugin-chart-country-map/src/countries/russia.geojson)</sup>.
<!-- Dosu Comment Footer -->
*To continue talking to [Dosu](https://dosu.dev), mention @dosu.*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] legacy-plugin-chart-country-map on the map of Russia Karelia is located on the territory of the Murmansk region [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #30326:
URL: https://github.com/apache/superset/issues/30326#issuecomment-3120711391
This seems to (still) not be fixed in the upstream data source. We're still open to PRs!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] legacy-plugin-chart-country-map on the map of Russia Karelia is located on the territory of the Murmansk region [superset]
Posted by "dosubot[bot] (via GitHub)" <gi...@apache.org>.
dosubot[bot] commented on issue #30326:
URL: https://github.com/apache/superset/issues/30326#issuecomment-2359312800
<!-- Greeting -->
Hello @SBIN2010! I'm here to assist you with any bugs, questions, or contributions. Let's work together to resolve the issue you're facing.
<!-- Answer -->
To fix the issue where Karelia is incorrectly displayed as part of the Murmansk region on the legacy-plugin-chart-country-map for Russia in Superset version 4.0.2, you need to ensure that the GeoJSON data for Karelia is correctly defined and not overlapping with the Murmansk region.
Here is the correct GeoJSON data for Karelia:
```geojson
{
"type": "Feature",
"properties": { "ISO": "RU-KR", "NAME_1": "Karelia" },
"geometry": {
"type": "Polygon",
"coordinates": [
[
[35.8583984375, 65.077929687500003],
[35.827343750000011, 65.036474609375006],
[35.84228515625, 65.00146484375],
[35.778710937500023, 64.976660156250006],
[35.680078125000023, 65.0576171875],
[35.621386718750017, 65.058789062499997],
[35.55859375, 65.093603515625006],
[35.52890625, 65.151074218749997],
[35.585742187500017, 65.167089843750006],
[35.608691406250017, 65.157128906249994],
[35.729101562500006, 65.197558593750003],
[35.816113281250011, 65.182080078124997],
[35.848437500000017, 65.142675781250006],
[35.8583984375, 65.077929687500003]
]
]
}
}
```
Ensure that this data is correctly placed in the `russia.geojson` file and that there are no overlapping coordinates with the Murmansk region. If the Murmansk region's data is incorrect, you will need to correct it similarly by ensuring its coordinates do not overlap with Karelia <sup>[[1]](https://github.com/apache/superset/blob/master/superset-frontend/plugins/legacy-plugin-chart-country-map/src/countries/russia.geojson)</sup>.
<!-- Dosu Comment Footer -->
*To continue talking to [Dosu](https://dosu.dev), mention @dosu.*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] legacy-plugin-chart-country-map on the map of Russia Karelia is located on the territory of the Murmansk region [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #30326:
URL: https://github.com/apache/superset/issues/30326#issuecomment-4035400103
Per @rusackas, the upstream map data source has not corrected the Karelia placement. If anyone can submit a corrected GeoJSON via the Jupyter notebook workflow, a PR updating the country map data would be welcome.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] legacy-plugin-chart-country-map on the map of Russia Karelia is located on the territory of the Murmansk region [superset]
Posted by "SBIN2010 (via GitHub)" <gi...@apache.org>.
SBIN2010 commented on issue #30326:
URL: https://github.com/apache/superset/issues/30326#issuecomment-2359322926
This is a little different from what I'm talking about. Here's an example of how it should be

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] legacy-plugin-chart-country-map on the map of Russia Karelia is located on the territory of the Murmansk region [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #30326:
URL: https://github.com/apache/superset/issues/30326#issuecomment-2802544906
We'd love to see a contribution to fix this in the Jupyter notebook (which tweaks/generates the GEOJson files). Here's some info on how to do it: https://preset.io/blog/how-and-when-and-why-to-update-apache-supersets-country-maps/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] legacy-plugin-chart-country-map on the map of Russia Karelia is located on the territory of the Murmansk region [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas closed issue #30326: legacy-plugin-chart-country-map on the map of Russia Karelia is located on the territory of the Murmansk region
URL: https://github.com/apache/superset/issues/30326
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org