[jira] [Resolved] (REEF-779) Implement both null and type checking in equals functions

["Andrew Chung (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/REEF-779?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Chung resolved REEF-779.
-------------------------------
    Resolution: Fixed

> Implement both null and type checking in equals functions 
> ----------------------------------------------------------
>
>                 Key: REEF-779
>                 URL: https://issues.apache.org/jira/browse/REEF-779
>             Project: REEF
>          Issue Type: Bug
>    Affects Versions: 0.12
>            Reporter: Dongjoon Hyun
>            Assignee: Dongjoon Hyun
>            Priority: Minor
>             Fix For: 0.13
>
>
> `equals` functions should handle `null` and other type objects. Most REEF classes already implements that function properly like the following.
> {code}
> public boolean equals(final Object o) {
>     if (this == o) {
>       return true;
>     }
>     if (o == null || getClass() != o.getClass()) {
>       return false;
>     }
>     ...
> }
> {code}
> This issue addresses the following classes needed to be changed.
>  * reef-io : StringIdentifier
>  * reef-tang: TangImpl.java, AbstractNode, ConstructorArgImpl, ConstructorDefImpl.java
>  * reef-wake: SocketRemoteIdentifier, Tuple2, TestRemoteIdentifier



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)