[GitHub] [incubator-doris] imay commented on a change in pull request #1872: Check transaction_id in TClearTransactionTaskRequest

[GitBox <gi...@apache.org>]

imay commented on a change in pull request #1872: Check transaction_id in TClearTransactionTaskRequest
URL: https://github.com/apache/incubator-doris/pull/1872#discussion_r328066818
 
 

 ##########
 File path: be/src/agent/task_worker_pool.cpp
 ##########
 @@ -960,8 +960,10 @@ void* TaskWorkerPool::_clear_transaction_task_worker_thread_callback(void* arg_t
         vector<string> error_msgs;
         TStatus task_status;
 
-        worker_pool_this->_env->storage_engine()->clear_transaction_task(
-            clear_transaction_task_req.transaction_id, clear_transaction_task_req.partition_id);
+        if (clear_transaction_task_req.transaction_id > 0) {
 
 Review comment:
   Add comment to explain why there will be transaction id less than 0.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org