[jira] [Commented] (IVY-1431) Also copy original metadata artifact (e.g. POM) on ivy:install

["Nicolas Lalevée (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IVY-1431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13811773#comment-13811773 ] 

Nicolas Lalevée commented on IVY-1431:
--------------------------------------

Some comments on the patch:

* in DefaultRepositoryCacheManager, rather than trying to guess what the origin is and so some sort of reverse engineering, what do you think about adding a new metadata, like {{artifact:ivy#ivy#xml#-761783604.orginl=artifact:commons-lang#pom.original#pom#-820436446}}

* in InstallEngine, why is there so much tests to check if there is an origin ? The 3 firsts tests seems decent, the 4th one seems to be about being safer than sorry, but the 2 last ones about the type seems weird to me. Could you elaborate on why they are needed ?

> Also copy original metadata artifact (e.g. POM) on ivy:install
> --------------------------------------------------------------
>
>                 Key: IVY-1431
>                 URL: https://issues.apache.org/jira/browse/IVY-1431
>             Project: Ivy
>          Issue Type: Improvement
>            Reporter: Erwin Tratar
>            Priority: Minor
>              Labels: patch
>         Attachments: ivy-install-pom.patch
>
>
> Suppose you provide some module, which you are developing with Ivy and that has external dependencies (or even worse: non publically available dependencies). Then you might want to publish the module plus all dependencies to a filesystem repository, which then can be redistributed and which is usable for offline builds. 
> So far, no problem. But if you do not want to or even can't force your consumers to use Ivy, then while you can create this "offline repository" in Maven layout, it still is not usable with Maven because the POMs of all your dependencies are missing. While Ivy remembers them (*.orig Files), they are not used.
> The attached patch will copy the cached original metadata in the install operation if it's type ends in ".original". Also, the restoring of the OriginArtifact from the Cache is modified to actually restore the OriginArtifact's orignal Artifact correctly.



--
This message was sent by Atlassian JIRA
(v6.1#6144)