[jira] [Comment Edited] (CASSANDRA-6283) Windows 7 data files kept open / can't be deleted after compaction.

["Joshua McKenzie (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-6283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13962324#comment-13962324 ] 

Joshua McKenzie edited comment on CASSANDRA-6283 at 4/7/14 10:16 PM:
---------------------------------------------------------------------

Erring on the side of less complexity is never a bad thing in my book

To be safe leaving mmap in we'd have to disable snapshot deletion via nodetool to go along with removing it from repair which smells super-hacky - I'm on board (edit) - with disabling mmap on Windows.  I'll create a ticket for removing mmap on index files and disabling mmap'ed I/O on Windows.  We reference 4050 and that from here and I think this ticket's done.  


was (Author: joshuamckenzie):
Erring on the side of less complexity is never a bad thing in my book

To be safe leaving mmap in we'd have to disable snapshot deletion via nodetool to go along with removing it from repair which smells super-hacky - I'm on board.  I'll create a ticket for removing mmap on index files and disabling mmap'ed I/O on Windows.  We reference 4050 and that from here and I think this ticket's done.  

> Windows 7 data files kept open / can't be deleted after compaction.
> -------------------------------------------------------------------
>
>                 Key: CASSANDRA-6283
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-6283
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>         Environment: Windows 7 (32) / Java 1.7.0.45
>            Reporter: Andreas Schnitzerling
>            Assignee: Joshua McKenzie
>              Labels: compaction
>             Fix For: 2.0.7
>
>         Attachments: 6283_StreamWriter_patch.txt, leakdetect.patch, neighbor-log.zip, root-log.zip, screenshot-1.jpg, system.log
>
>
> Files cannot be deleted, patch CASSANDRA-5383 (Win7 deleting problem) doesn't help on Win-7 on Cassandra 2.0.2. Even 2.1 Snapshot is not running. The cause is: Opened file handles seem to be lost and not closed properly. Win 7 blames, that another process is still using the file (but its obviously cassandra). Only restart of the server makes the files deleted. But after heavy using (changes) of tables, there are about 24K files in the data folder (instead of 35 after every restart) and Cassandra crashes. I experiminted and I found out, that a finalizer fixes the problem. So after GC the files will be deleted (not optimal, but working fine). It runs now 2 days continously without problem. Possible fix/test:
> I wrote the following finalizer at the end of class org.apache.cassandra.io.util.RandomAccessReader:
> {code:title=RandomAccessReader.java|borderStyle=solid}
> @Override
> protected void finalize() throws Throwable {
> 	deallocate();
> 	super.finalize();
> }
> {code}
> Can somebody test / develop / patch it? Thx.



--
This message was sent by Atlassian JIRA
(v6.2#6252)