You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Darrel Schneider <ds...@pivotal.io> on 2015/08/14 01:22:55 UTC
Review Request 37450: GEODE-216: Handle any exception that might be
thrown
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37450/
-----------------------------------------------------------
Review request for geode and Dan Smith.
Bugs: GEODE-216
https://issues.apache.org/jira/browse/GEODE-216
Repository: geode
Description
-------
The old code was trying to prevent a deadlock under some certain
conditions. But if it can not get a PR because of an exception
then a deadlock is not possible. So the new code just catches
and ignores exceptions and falls through to the code that will
process the message the old way. This code will encounter the
same exception and has the proper logic to handle it.
Diffs
-----
gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/GetMessage.java c8d990d7e2dba1f61a2aa7f9df703c0be6306a9d
Diff: https://reviews.apache.org/r/37450/diff/
Testing
-------
RedisDistDUnitTest was failing for me without this change.
With it testConcCreateDestroy has been passing every time.
Thanks,
Darrel Schneider
Re: Review Request 37450: GEODE-216: Handle any exception that might
be thrown
Posted by Dan Smith <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37450/#review95347
-----------------------------------------------------------
Ship it!
Ship It!
- Dan Smith
On Aug. 13, 2015, 11:22 p.m., Darrel Schneider wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37450/
> -----------------------------------------------------------
>
> (Updated Aug. 13, 2015, 11:22 p.m.)
>
>
> Review request for geode and Dan Smith.
>
>
> Bugs: GEODE-216
> https://issues.apache.org/jira/browse/GEODE-216
>
>
> Repository: geode
>
>
> Description
> -------
>
> The old code was trying to prevent a deadlock under some certain
> conditions. But if it can not get a PR because of an exception
> then a deadlock is not possible. So the new code just catches
> and ignores exceptions and falls through to the code that will
> process the message the old way. This code will encounter the
> same exception and has the proper logic to handle it.
>
>
> Diffs
> -----
>
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/GetMessage.java c8d990d7e2dba1f61a2aa7f9df703c0be6306a9d
>
> Diff: https://reviews.apache.org/r/37450/diff/
>
>
> Testing
> -------
>
> RedisDistDUnitTest was failing for me without this change.
> With it testConcCreateDestroy has been passing every time.
>
>
> Thanks,
>
> Darrel Schneider
>
>