[GitHub] [incubator-nuttx] a-lunev commented on a change in pull request #4639: tcp_timer: eliminated false decrements of conn->timer in case of multiple network adapters.

[GitBox <gi...@apache.org>]

a-lunev commented on a change in pull request #4639:
URL: https://github.com/apache/incubator-nuttx/pull/4639#discussion_r726274522



##########
File path: net/devif/devif_poll.c
##########
@@ -361,17 +363,22 @@ static inline int devif_poll_icmp(FAR struct net_driver_s *dev,
 
   while (!bstop && (conn = icmp_nextconn(conn)) != NULL)
     {
-      /* Perform the ICMP poll */
+      /* Skip ICMP connections that are bound to other polling devices */
 
-      icmp_poll(dev, conn);
+      if (dev == conn->dev)

Review comment:
       As I've understood, icmpv6_poll is a special case. It can receive NULL conn argument.
   There is explanation of it in comments as follows:
   ```
             /* Perform the ICMPV6 poll
              * Note: conn equal NULL in the first iteration means poll dev's
              * callback list since icmpv6_autoconfig and icmpv6_neighbor still
              * append it's callback into this list.
              */
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org