You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by "James Peach (Created) (JIRA)" <ji...@apache.org> on 2011/12/08 03:55:41 UTC
[jira] [Created] (TS-1042) PATCH: correct debug message in FetchSM
PATCH: correct debug message in FetchSM
---------------------------------------
Key: TS-1042
URL: https://issues.apache.org/jira/browse/TS-1042
Project: Traffic Server
Issue Type: Bug
Components: HTTP
Reporter: James Peach
Priority: Minor
In the FetchSM module, there is a debug message that can walk off the end of the buffer. This patch corrects that by limiting the printed string to the known length.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1042) PATCH: correct debug message in
FetchSM
Posted by "Leif Hedstrom (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13166222#comment-13166222 ]
Leif Hedstrom commented on TS-1042:
-----------------------------------
Hmmm, why "%*.*s", length, length) ? Everywhere else we just do "%.*s", length, string)
> PATCH: correct debug message in FetchSM
> ---------------------------------------
>
> Key: TS-1042
> URL: https://issues.apache.org/jira/browse/TS-1042
> Project: Traffic Server
> Issue Type: Bug
> Components: HTTP
> Reporter: James Peach
> Assignee: Igor Galić
> Priority: Minor
> Fix For: 3.1.2
>
> Attachments: 0004-Fix-FetchSM-debugging-message.patch
>
>
> In the FetchSM module, there is a debug message that can walk off the end of the buffer. This patch corrects that by limiting the printed string to the known length.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (TS-1042) PATCH: correct debug message in FetchSM
Posted by "Igor Galić (Assigned JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Galić reassigned TS-1042:
------------------------------
Assignee: Igor Galić
> PATCH: correct debug message in FetchSM
> ---------------------------------------
>
> Key: TS-1042
> URL: https://issues.apache.org/jira/browse/TS-1042
> Project: Traffic Server
> Issue Type: Bug
> Components: HTTP
> Reporter: James Peach
> Assignee: Igor Galić
> Priority: Minor
> Attachments: 0004-Fix-FetchSM-debugging-message.patch
>
>
> In the FetchSM module, there is a debug message that can walk off the end of the buffer. This patch corrects that by limiting the printed string to the known length.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-1042) PATCH: correct debug message in FetchSM
Posted by "James Peach (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James Peach updated TS-1042:
----------------------------
Attachment: 0004-Fix-FetchSM-debugging-message.patch
> PATCH: correct debug message in FetchSM
> ---------------------------------------
>
> Key: TS-1042
> URL: https://issues.apache.org/jira/browse/TS-1042
> Project: Traffic Server
> Issue Type: Bug
> Components: HTTP
> Reporter: James Peach
> Priority: Minor
> Attachments: 0004-Fix-FetchSM-debugging-message.patch
>
>
> In the FetchSM module, there is a debug message that can walk off the end of the buffer. This patch corrects that by limiting the printed string to the known length.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1042) PATCH: correct debug message in
FetchSM
Posted by "James Peach (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13166330#comment-13166330 ]
James Peach commented on TS-1042:
---------------------------------
To be honest, it's mostly from habit. However "%*.*s" prints exactly the number of bytes whereas "%.*s" prints up to the number of bytes. In this particular case we know the number of bytes and we want to print all of them so "%*.*s" seems like the right choice. But "%.*s" will fix the bug just as well.
> PATCH: correct debug message in FetchSM
> ---------------------------------------
>
> Key: TS-1042
> URL: https://issues.apache.org/jira/browse/TS-1042
> Project: Traffic Server
> Issue Type: Bug
> Components: HTTP
> Reporter: James Peach
> Assignee: Igor Galić
> Priority: Minor
> Fix For: 3.1.2
>
> Attachments: 0004-Fix-FetchSM-debugging-message.patch
>
>
> In the FetchSM module, there is a debug message that can walk off the end of the buffer. This patch corrects that by limiting the printed string to the known length.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1042) PATCH: correct debug message in
FetchSM
Posted by "Igor Galić (Commented JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13166115#comment-13166115 ]
Igor Galić commented on TS-1042:
--------------------------------
crawling through {{printf(3)}}, giving up, asking {{##C}} - I now know what {{printf("%*.*s", length, length, string);}} does!
Thank you again for the patch, I aplied it in r1212343
> PATCH: correct debug message in FetchSM
> ---------------------------------------
>
> Key: TS-1042
> URL: https://issues.apache.org/jira/browse/TS-1042
> Project: Traffic Server
> Issue Type: Bug
> Components: HTTP
> Reporter: James Peach
> Assignee: Igor Galić
> Priority: Minor
> Fix For: 3.1.2
>
> Attachments: 0004-Fix-FetchSM-debugging-message.patch
>
>
> In the FetchSM module, there is a debug message that can walk off the end of the buffer. This patch corrects that by limiting the printed string to the known length.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira