You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by ja...@apache.org on 2018/10/01 21:14:14 UTC
samza git commit: Update doc side menu JS to allow for external links
Repository: samza
Updated Branches:
refs/heads/master 5e4ba7de1 -> 334d24e68
Update doc side menu JS to allow for external links
Author: Angela Murrell <am...@gmail.com>
Reviewers: Jagadish<ja...@apache.org>
Closes #679 from amurrell/master
Project: http://git-wip-us.apache.org/repos/asf/samza/repo
Commit: http://git-wip-us.apache.org/repos/asf/samza/commit/334d24e6
Tree: http://git-wip-us.apache.org/repos/asf/samza/tree/334d24e6
Diff: http://git-wip-us.apache.org/repos/asf/samza/diff/334d24e6
Branch: refs/heads/master
Commit: 334d24e6831679aa4b440e99e613acac7778afe4
Parents: 5e4ba7d
Author: Angela Murrell <am...@gmail.com>
Authored: Mon Oct 1 14:14:11 2018 -0700
Committer: Jagadish <jv...@linkedin.com>
Committed: Mon Oct 1 14:14:11 2018 -0700
----------------------------------------------------------------------
docs/_layouts/default.html | 2 +-
docs/js/main.new.js | 17 +++++++++++++++--
2 files changed, 16 insertions(+), 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/samza/blob/334d24e6/docs/_layouts/default.html
----------------------------------------------------------------------
diff --git a/docs/_layouts/default.html b/docs/_layouts/default.html
index 23897b0..74ca7ab 100644
--- a/docs/_layouts/default.html
+++ b/docs/_layouts/default.html
@@ -64,7 +64,7 @@
<a class="button" href="/startup/hello-samza/{{site.version}}">
Quick Start
</a>
- <a class="button" href="/startup/hello-samza/{{site.version}}">
+ <a class="button" href="/case-studies/">
Case studies
</a>
</div>
http://git-wip-us.apache.org/repos/asf/samza/blob/334d24e6/docs/js/main.new.js
----------------------------------------------------------------------
diff --git a/docs/js/main.new.js b/docs/js/main.new.js
index b7e04fa..6e8d5e2 100644
--- a/docs/js/main.new.js
+++ b/docs/js/main.new.js
@@ -276,12 +276,19 @@ var buildDocMenu = (status, body, docMenu) => {
} else if (h4Link) {
var h4LinkEl = document.createElement('a');
- var linkDestination = docMenuLinkBase + h4Link.getAttribute('href');
+ var h4href =h4Link.getAttribute('href');
+ var linkDestination = h4href.match(/^http/) ? h4href : docMenuLinkBase + h4href;
var linkText = h4Link.text.trim();
h4LinkEl.classList.add('side-navigation__group-item');
h4LinkEl.setAttribute('href', linkDestination);
h4LinkEl.setAttribute('data-match-active', h4Link.getAttribute('data-match-active'));
+
+ if (h4href.match(/^http/)) {
+ h4LinkEl.setAttribute('target', '_blank');
+ h4LinkEl.setAttribute('rel', 'nofollow');
+ }
+
h4LinkEl.text = linkText;
docMenu.appendChild(h4LinkEl);
@@ -302,7 +309,8 @@ var buildDocMenu = (status, body, docMenu) => {
Array.from(listItems).forEach( listItem => {
var link = listItem.querySelector('a');
- linkDestination = docMenuLinkBase + link.getAttribute('href');
+ var linkhref = link.getAttribute('href');
+ linkDestination = linkhref.match(/^http/) ? linkhref : docMenuLinkBase + linkhref;
linkText = link.text.trim();
@@ -311,6 +319,11 @@ var buildDocMenu = (status, body, docMenu) => {
newLink.setAttribute('href', linkDestination);
newLink.text = linkText;
+ if (linkhref.match(/^http/)) {
+ newLink.setAttribute('target', '_blank');
+ newLink.setAttribute('rel', 'nofollow');
+ }
+
itemsDiv.appendChild(newLink);
})