[GitHub] [incubator-brpc] wwbmmm commented on a change in pull request #1669: Fix C++ compile issue and clang compile issue

[GitBox <gi...@apache.org>]

wwbmmm commented on a change in pull request #1669:
URL: https://github.com/apache/incubator-brpc/pull/1669#discussion_r790395641



##########
File path: src/brpc/redis.h
##########
@@ -107,21 +107,21 @@ class RedisRequest : public ::google::protobuf::Message {
     bool SerializeTo(butil::IOBuf* buf) const;
 
     // Protobuf methods.
-    RedisRequest* New() const;
-    void CopyFrom(const ::google::protobuf::Message& from);
-    void MergeFrom(const ::google::protobuf::Message& from);
+    RedisRequest* New() const override;

Review comment:
       Why "override" is needed only in "redis.h" while not in "thrift_message.h" or "nshead_message.h" or other headers files? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org