You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by "Yann Le Du (JIRA)" <ji...@codehaus.org> on 2005/06/16 16:41:26 UTC
[jira] Created: (MNG-478) war:war warSourceExcludes parameter not used when set in the POM
war:war warSourceExcludes parameter not used when set in the POM
----------------------------------------------------------------
Key: MNG-478
URL: http://jira.codehaus.org/browse/MNG-478
Project: Maven 2
Type: Bug
Components: maven-plugins
Versions: 2.0-alpha-2
Environment: Windows XP
Reporter: Yann Le Du
I got the following in my POM for a WAR-packaged project :
<build>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-war-plugin</artifactId>
<configuration>
<warSourceExcludes>**/test.html</warSourceExcludes>
</configuration>
</plugin>
</plugins>
</build>
I run "m2 install". The file src/main/webapp/test.html is included in the resulting WAR, but, unless I'm mistaken, it shouldn't.
I've tried with the following patterns :
test.html
*/test.html
**/test.html
*\test.html
**\test.html
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MNG-478) war:war warSourceExcludes parameter not used when set in the POM
Posted by "Trygve Laugstol (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-478?page=comments#action_44609 ]
Trygve Laugstol commented on MNG-478:
-------------------------------------
Patch applied, waiting a bit longer for a test case.
> war:war warSourceExcludes parameter not used when set in the POM
> ----------------------------------------------------------------
>
> Key: MNG-478
> URL: http://jira.codehaus.org/browse/MNG-478
> Project: Maven 2
> Type: Bug
> Components: maven-plugins
> Versions: 2.0-alpha-2
> Environment: Windows XP
> Reporter: Yann Le Du
> Fix For: 2.0-beta-1
> Attachments: WarMojo.diff
>
>
> I got the following in my POM for a WAR-packaged project :
> <build>
> <plugins>
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-war-plugin</artifactId>
>
> <configuration>
> <warSourceExcludes>**/test.html</warSourceExcludes>
> </configuration>
> </plugin>
> </plugins>
> </build>
> I run "m2 install". The file src/main/webapp/test.html is included in the resulting WAR, but, unless I'm mistaken, it shouldn't.
> I've tried with the following patterns :
> test.html
> */test.html
> **/test.html
> *\test.html
> **\test.html
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MNG-478) war:war warSourceExcludes parameter not used when set in the POM
Posted by "Yann Le Du (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-478?page=comments#action_41395 ]
Yann Le Du commented on MNG-478:
--------------------------------
OK, the main example was a bad one :) but as I said I tried with other patterns, including mere test.html ; I just tried again, just in case, and it still doesn't work.
Let me know if you need more info.
> war:war warSourceExcludes parameter not used when set in the POM
> ----------------------------------------------------------------
>
> Key: MNG-478
> URL: http://jira.codehaus.org/browse/MNG-478
> Project: Maven 2
> Type: Bug
> Components: maven-plugins
> Versions: 2.0-alpha-2
> Environment: Windows XP
> Reporter: Yann Le Du
>
>
> I got the following in my POM for a WAR-packaged project :
> <build>
> <plugins>
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-war-plugin</artifactId>
>
> <configuration>
> <warSourceExcludes>**/test.html</warSourceExcludes>
> </configuration>
> </plugin>
> </plugins>
> </build>
> I run "m2 install". The file src/main/webapp/test.html is included in the resulting WAR, but, unless I'm mistaken, it shouldn't.
> I've tried with the following patterns :
> test.html
> */test.html
> **/test.html
> *\test.html
> **\test.html
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Closed: (MNG-478) war:war warSourceExcludes parameter not used when set in the POM
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-478?page=all ]
Brett Porter closed MNG-478:
----------------------------
Assign To: Trygve Laugstol
Resolution: Fixed
we'd still appreciate a test case, but closing it off since it is fixed
> war:war warSourceExcludes parameter not used when set in the POM
> ----------------------------------------------------------------
>
> Key: MNG-478
> URL: http://jira.codehaus.org/browse/MNG-478
> Project: Maven 2
> Type: Bug
> Components: maven-plugins
> Versions: 2.0-alpha-2
> Environment: Windows XP
> Reporter: Yann Le Du
> Assignee: Trygve Laugstol
> Fix For: 2.0-beta-1
> Attachments: WarMojo.diff
>
>
> I got the following in my POM for a WAR-packaged project :
> <build>
> <plugins>
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-war-plugin</artifactId>
>
> <configuration>
> <warSourceExcludes>**/test.html</warSourceExcludes>
> </configuration>
> </plugin>
> </plugins>
> </build>
> I run "m2 install". The file src/main/webapp/test.html is included in the resulting WAR, but, unless I'm mistaken, it shouldn't.
> I've tried with the following patterns :
> test.html
> */test.html
> **/test.html
> *\test.html
> **\test.html
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Updated: (MNG-478) war:war warSourceExcludes parameter not used when set in the POM
Posted by "Greg Case (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-478?page=all ]
Greg Case updated MNG-478:
--------------------------
Attachment: WarMojo.diff
Here is my patch for this issue. The warSourceExcludes attribute is no longer ignored, as well as the "default" excludes. The defaultExcludeList is still duplicated, as its also in the AssemblyMojo and the DirectoryScanner. I left it alone because I wasn't sure where it would ultimately end up.
I was not able to implement the multiple warSourceExcludes elements, as I could not figure out how to correctly configure the plugin in my .pom after I changed the warSourceExcludes property from String to List.
Anyways, I hope this patch helps. I tried to keep as consistent as I could with the existing coding style. Let me know if there is anything I should have done differently.
> war:war warSourceExcludes parameter not used when set in the POM
> ----------------------------------------------------------------
>
> Key: MNG-478
> URL: http://jira.codehaus.org/browse/MNG-478
> Project: Maven 2
> Type: Bug
> Components: maven-plugins
> Versions: 2.0-alpha-2
> Environment: Windows XP
> Reporter: Yann Le Du
> Fix For: 2.0-beta-1
> Attachments: WarMojo.diff
>
>
> I got the following in my POM for a WAR-packaged project :
> <build>
> <plugins>
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-war-plugin</artifactId>
>
> <configuration>
> <warSourceExcludes>**/test.html</warSourceExcludes>
> </configuration>
> </plugin>
> </plugins>
> </build>
> I run "m2 install". The file src/main/webapp/test.html is included in the resulting WAR, but, unless I'm mistaken, it shouldn't.
> I've tried with the following patterns :
> test.html
> */test.html
> **/test.html
> *\test.html
> **\test.html
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MNG-478) war:war warSourceExcludes parameter not used when set in the POM
Posted by "Greg Case (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-478?page=comments#action_44281 ]
Greg Case commented on MNG-478:
-------------------------------
After using Maven2 for sometime (and loving it), I would like to help out by taking a crack at submitting a patch for this issue, but wanted to get some ideas of how to aproach it before I start hacking away... Currently the WarMojo is using FileUtils.copyDirectoryStructure from plexus, which of course doesn't support excludes/includes.
I was thinking of modifying this to use an approach similar to how ResourcesMojo handles the copying, by using DirectoryScanner and setting the excludes/includs there. So my questions are:
1) Is this an appropriate approach?
2) Does it make sense to allow for multiple <warSourceExcludes> elements, rather than a single element with a comma-separated list? It would seem that multiple elements would be cleaner, and more consistent with the rest of the maven 2 project.
> war:war warSourceExcludes parameter not used when set in the POM
> ----------------------------------------------------------------
>
> Key: MNG-478
> URL: http://jira.codehaus.org/browse/MNG-478
> Project: Maven 2
> Type: Bug
> Components: maven-plugins
> Versions: 2.0-alpha-2
> Environment: Windows XP
> Reporter: Yann Le Du
> Fix For: 2.0-beta-1
>
>
> I got the following in my POM for a WAR-packaged project :
> <build>
> <plugins>
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-war-plugin</artifactId>
>
> <configuration>
> <warSourceExcludes>**/test.html</warSourceExcludes>
> </configuration>
> </plugin>
> </plugins>
> </build>
> I run "m2 install". The file src/main/webapp/test.html is included in the resulting WAR, but, unless I'm mistaken, it shouldn't.
> I've tried with the following patterns :
> test.html
> */test.html
> **/test.html
> *\test.html
> **\test.html
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Updated: (MNG-478) war:war warSourceExcludes parameter not used when set in the POM
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-478?page=all ]
Brett Porter updated MNG-478:
-----------------------------
Description:
I got the following in my POM for a WAR-packaged project :
<build>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-war-plugin</artifactId>
<configuration>
<warSourceExcludes>**/test.html</warSourceExcludes>
</configuration>
</plugin>
</plugins>
</build>
I run "m2 install". The file src/main/webapp/test.html is included in the resulting WAR, but, unless I'm mistaken, it shouldn't.
I've tried with the following patterns :
test.html
*/test.html
**/test.html
*\test.html
**\test.html
was:
I got the following in my POM for a WAR-packaged project :
<build>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-war-plugin</artifactId>
<configuration>
<warSourceExcludes>**/test.html</warSourceExcludes>
</configuration>
</plugin>
</plugins>
</build>
I run "m2 install". The file src/main/webapp/test.html is included in the resulting WAR, but, unless I'm mistaken, it shouldn't.
I've tried with the following patterns :
test.html
*/test.html
**/test.html
*\test.html
**\test.html
Complexity: Novice
both sound good to me. go for it, and thanks!
> war:war warSourceExcludes parameter not used when set in the POM
> ----------------------------------------------------------------
>
> Key: MNG-478
> URL: http://jira.codehaus.org/browse/MNG-478
> Project: Maven 2
> Type: Bug
> Components: maven-plugins
> Versions: 2.0-alpha-2
> Environment: Windows XP
> Reporter: Yann Le Du
> Fix For: 2.0-beta-1
>
>
> I got the following in my POM for a WAR-packaged project :
> <build>
> <plugins>
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-war-plugin</artifactId>
>
> <configuration>
> <warSourceExcludes>**/test.html</warSourceExcludes>
> </configuration>
> </plugin>
> </plugins>
> </build>
> I run "m2 install". The file src/main/webapp/test.html is included in the resulting WAR, but, unless I'm mistaken, it shouldn't.
> I've tried with the following patterns :
> test.html
> */test.html
> **/test.html
> *\test.html
> **\test.html
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MNG-478) war:war warSourceExcludes parameter not used when set in the POM
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-478?page=comments#action_41394 ]
Brett Porter commented on MNG-478:
----------------------------------
I'm pretty sure ** has to match at least one directory. Try <warSourceExcludes>test.html</warSourceExcludes>
> war:war warSourceExcludes parameter not used when set in the POM
> ----------------------------------------------------------------
>
> Key: MNG-478
> URL: http://jira.codehaus.org/browse/MNG-478
> Project: Maven 2
> Type: Bug
> Components: maven-plugins
> Versions: 2.0-alpha-2
> Environment: Windows XP
> Reporter: Yann Le Du
>
>
> I got the following in my POM for a WAR-packaged project :
> <build>
> <plugins>
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-war-plugin</artifactId>
>
> <configuration>
> <warSourceExcludes>**/test.html</warSourceExcludes>
> </configuration>
> </plugin>
> </plugins>
> </build>
> I run "m2 install". The file src/main/webapp/test.html is included in the resulting WAR, but, unless I'm mistaken, it shouldn't.
> I've tried with the following patterns :
> test.html
> */test.html
> **/test.html
> *\test.html
> **\test.html
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Updated: (MNG-478) war:war warSourceExcludes parameter not used when set in the POM
Posted by "Emmanuel Venisse (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-478?page=all ]
Emmanuel Venisse updated MNG-478:
---------------------------------
Fix Version: 2.0-beta-1
excludes and includes aren't use in the current implementation
> war:war warSourceExcludes parameter not used when set in the POM
> ----------------------------------------------------------------
>
> Key: MNG-478
> URL: http://jira.codehaus.org/browse/MNG-478
> Project: Maven 2
> Type: Bug
> Components: maven-plugins
> Versions: 2.0-alpha-2
> Environment: Windows XP
> Reporter: Yann Le Du
> Fix For: 2.0-beta-1
>
>
> I got the following in my POM for a WAR-packaged project :
> <build>
> <plugins>
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-war-plugin</artifactId>
>
> <configuration>
> <warSourceExcludes>**/test.html</warSourceExcludes>
> </configuration>
> </plugin>
> </plugins>
> </build>
> I run "m2 install". The file src/main/webapp/test.html is included in the resulting WAR, but, unless I'm mistaken, it shouldn't.
> I've tried with the following patterns :
> test.html
> */test.html
> **/test.html
> *\test.html
> **\test.html
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org