You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "rithwik-db (via GitHub)" <gi...@apache.org> on 2023/08/03 16:57:18 UTC
[GitHub] [spark] rithwik-db commented on a diff in pull request #42308: [Spark Ticket][WIP]Added a warning to pop up in the case the user doesn't use gpus
rithwik-db commented on code in PR #42308:
URL: https://github.com/apache/spark/pull/42308#discussion_r1283478709
##########
python/pyspark/ml/deepspeed/deepspeed_distributor.py:
##########
@@ -97,6 +98,8 @@ def __init__(
_ssl_conf=DeepspeedTorchDistributor._DEEPSPEED_SSL_CONF,
)
self.cleanup_deepspeed_conf = False
+ if not useGpu:
+ warnings.warn(message="Deepspeed usage with CPUs is not very well supported at this time.")
Review Comment:
Just say "DeepspeedDistributor usage with CPUs is not supported at this time".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org