You are viewing a plain text version of this content. The canonical link for it is here.

Posted to devnull@infra.apache.org by "markusthoemmes (GitHub)" <gi...@apache.org> on 2018/08/23 09:34:43 UTC

[GitHub] [incubator-openwhisk] markusthoemmes commented on pull request #3984: Simplify configuring OpenWhisk

Can we generalize this a bit? As of now, this script is very non-OpenWhisk-dependent. What about:

```bash
if [ -n "$CONFIGFILE_CONTENT" ]
then
    location="/config.conf"
    echo "$CONFIGFILE_CONTENT" > "$location"
    props+=("-Dconfig.file='$location'")
fi
```

Note: I switched from `printf` to `echo`. Any reason to use `printf` here?
Note 2: Please fix the indenting from 3 to 4 spaces.

[ Full content available at: https://github.com/apache/incubator-openwhisk/pull/3984 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org