You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "mbien (via GitHub)" <gi...@apache.org> on 2024/05/03 23:34:04 UTC

[PR] Bump MavenVersionSettings fallback versions. [netbeans]

mbien opened a new pull request, #7357:
URL: https://github.com/apache/netbeans/pull/7357

   bump some defaults


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] Bump MavenVersionSettings fallback versions. [netbeans]

Posted by "vieiro (via GitHub)" <gi...@apache.org>.
vieiro commented on PR #7357:
URL: https://github.com/apache/netbeans/pull/7357#issuecomment-2096844407

   Looks ok to me.
   
   I was wondering if we should update the [Releasing Apache NetBeans Maven Utilities](https://cwiki.apache.org/confluence/display/NETBEANS/Releasing+Apache+NetBeans+Maven+utilities+related+artefacts) and/or the [Apache NetBeans Release README](https://cwiki.apache.org/confluence/display/NETBEANS/Apache+NetBeans+Release+README) with this PR as a template?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] Bump MavenVersionSettings fallback versions. [netbeans]

Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on PR #7357:
URL: https://github.com/apache/netbeans/pull/7357#issuecomment-2098369791

   Definitely don't update the release readme to follow this!  If there's a decision to always have the fallback be the in use release, then it should be templated in like every other use of the current version in the build.  The JSON metainfo already has this value.
   
   No argument against this as is, depending on @ebarboni take.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] Bump MavenVersionSettings fallback versions. [netbeans]

Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #7357:
URL: https://github.com/apache/netbeans/pull/7357#issuecomment-2098503123

   > .. then it should be templated in like every other use of the current version in the build
   
   @neilcsmith-net in worst case we switch all version strings to functions like in https://github.com/apache/netbeans/pull/6213 :P -> Chronographic Versioning


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] Bump MavenVersionSettings fallback versions. [netbeans]

Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #7357:
URL: https://github.com/apache/netbeans/pull/7357#issuecomment-2098351496

   running tests again with everything enabled


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] Bump MavenVersionSettings fallback versions. [netbeans]

Posted by "vieiro (via GitHub)" <gi...@apache.org>.
vieiro commented on PR #7357:
URL: https://github.com/apache/netbeans/pull/7357#issuecomment-2097554264

   > @vieiro well, this PR here isn't strictly needed since versions would be just the defaults if the index is not (yet) available or disabled by the user. I am also not sure if this is even a good idea, since this could cause issues during testing. Both nb-maven-plugin 14.1 and NB 22 are not released yet - if you don't have them in your local repo some wizards will likely fail.
   > 
   > I never updated a version to a not yet released lib so far.
   
   Exactly! That's why I was asking. I think we could set up a local repo with artifacts and then re-test things, but that would complicate the release process, right?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] Bump MavenVersionSettings fallback versions. [netbeans]

Posted by "ebarboni (via GitHub)" <gi...@apache.org>.
ebarboni commented on PR #7357:
URL: https://github.com/apache/netbeans/pull/7357#issuecomment-2098394769

   the only issue could be mistake on populating artefacts for RELEAS220 happens only once in history :D


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] Bump MavenVersionSettings fallback versions. [netbeans]

Posted by "ebarboni (via GitHub)" <gi...@apache.org>.
ebarboni merged PR #7357:
URL: https://github.com/apache/netbeans/pull/7357


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] Bump MavenVersionSettings fallback versions. [netbeans]

Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #7357:
URL: https://github.com/apache/netbeans/pull/7357#issuecomment-2096870299

   > I was wondering if we should update the [Releasing Apache NetBeans Maven Utilities](https://cwiki.apache.org/confluence/display/NETBEANS/Releasing+Apache+NetBeans+Maven+utilities+related+artefacts) and/or the [Apache NetBeans Release README](https://cwiki.apache.org/confluence/display/NETBEANS/Apache+NetBeans+Release+README) with this PR as a template?
   
   @vieiro well, this PR here isn't strictly needed since versions would be just the defaults if the index is not (yet) available or disabled by the user. I am also not sure if this is even a good idea, since this could cause issues during testing. Both nb-maven-plugin 14.1 and NB 22 are not released yet - if you don't have them in your local repo some wizards will likely fail.
   
   I never updated a version to a not yet released lib so far.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists