You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2019/12/31 03:23:55 UTC
[GitHub] [skywalking] codecov-io commented on issue #4152: [Feature] Add tag
annotation to allow tagging span with annotation
codecov-io commented on issue #4152: [Feature] Add tag annotation to allow tagging span with annotation
URL: https://github.com/apache/skywalking/pull/4152#issuecomment-569856019
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4152?src=pr&el=h1) Report
> Merging [#4152](https://codecov.io/gh/apache/skywalking/pull/4152?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/1ee14fbbc8251a1faa5f3851d4f7d92f9ec1ab15?src=pr&el=desc) will **decrease** coverage by `0.09%`.
> The diff coverage is `11.62%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/4152/graphs/tree.svg?width=650&token=qrILxY5yA8&height=150&src=pr)](https://codecov.io/gh/apache/skywalking/pull/4152?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4152 +/- ##
=========================================
- Coverage 27.13% 27.03% -0.1%
=========================================
Files 1145 1147 +2
Lines 25105 25141 +36
Branches 3631 3641 +10
=========================================
- Hits 6812 6797 -15
- Misses 17690 17739 +49
- Partials 603 605 +2
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4152?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...it/activation/trace/TraceAnnotationActivation.java](https://codecov.io/gh/apache/skywalking/pull/4152/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC10cmFjZS1hY3RpdmF0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L2FjdGl2YXRpb24vdHJhY2UvVHJhY2VBbm5vdGF0aW9uQWN0aXZhdGlvbi5qYXZh) | `0% <ø> (ø)` | :arrow_up: |
| [.../customize/interceptor/BaseInterceptorMethods.java](https://codecov.io/gh/apache/skywalking/pull/4152/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvb3B0aW9uYWwtcGx1Z2lucy9jdXN0b21pemUtZW5oYW5jZS1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3BsdWdpbi9jdXN0b21pemUvaW50ZXJjZXB0b3IvQmFzZUludGVyY2VwdG9yTWV0aG9kcy5qYXZh) | `0% <ø> (ø)` | :arrow_up: |
| [...agent/core/plugin/match/MethodAnnotationMatch.java](https://codecov.io/gh/apache/skywalking/pull/4152/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL01ldGhvZEFubm90YXRpb25NYXRjaC5qYXZh) | `0% <0%> (ø)` | :arrow_up: |
| [...lking/apm/agent/core/util/CustomizeExpression.java](https://codecov.io/gh/apache/skywalking/pull/4152/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9DdXN0b21pemVFeHByZXNzaW9uLmphdmE=) | `0% <0%> (ø)` | |
| [...re/plugin/match/logical/LogicalMatchOperation.java](https://codecov.io/gh/apache/skywalking/pull/4152/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL2xvZ2ljYWwvTG9naWNhbE1hdGNoT3BlcmF0aW9uLmphdmE=) | `0% <0%> (ø)` | :arrow_up: |
| [...tivation/trace/TagAnnotationMethodInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/4152/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC10cmFjZS1hY3RpdmF0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L2FjdGl2YXRpb24vdHJhY2UvVGFnQW5ub3RhdGlvbk1ldGhvZEludGVyY2VwdG9yLmphdmE=) | `0% <0%> (ø)` | |
| [...lkit/activation/trace/TagAnnotationActivation.java](https://codecov.io/gh/apache/skywalking/pull/4152/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC10cmFjZS1hY3RpdmF0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L2FjdGl2YXRpb24vdHJhY2UvVGFnQW5ub3RhdGlvbkFjdGl2YXRpb24uamF2YQ==) | `0% <0%> (ø)` | |
| [...vation/trace/TraceAnnotationMethodInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/4152/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC10cmFjZS1hY3RpdmF0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L2FjdGl2YXRpb24vdHJhY2UvVHJhY2VBbm5vdGF0aW9uTWV0aG9kSW50ZXJjZXB0b3IuamF2YQ==) | `50% <45.45%> (-20%)` | :arrow_down: |
| ... and [2 more](https://codecov.io/gh/apache/skywalking/pull/4152/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4152?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4152?src=pr&el=footer). Last update [1ee14fb...e0e3cc2](https://codecov.io/gh/apache/skywalking/pull/4152?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services