You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by vi...@apache.org on 2020/10/28 08:31:01 UTC
[incubator-superset] 07/08: fix(crud): set default extra value
(#11262)
This is an automated email from the ASF dual-hosted git repository.
villebro pushed a commit to branch 0.38
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git
commit 44b7e8e6e8335f42c6c11e74f6b28e9603488f71
Author: Ville Brofeldt <33...@users.noreply.github.com>
AuthorDate: Wed Oct 14 19:05:20 2020 +0300
fix(crud): set default extra value (#11262)
---
superset-frontend/src/views/CRUD/data/database/DatabaseModal.tsx | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/superset-frontend/src/views/CRUD/data/database/DatabaseModal.tsx b/superset-frontend/src/views/CRUD/data/database/DatabaseModal.tsx
index f0e2c6c..0c7ecfd 100644
--- a/superset-frontend/src/views/CRUD/data/database/DatabaseModal.tsx
+++ b/superset-frontend/src/views/CRUD/data/database/DatabaseModal.tsx
@@ -126,6 +126,9 @@ const DatabaseModal: FunctionComponent<DatabaseModalProps> = ({
const [isHidden, setIsHidden] = useState<boolean>(true);
const isEditMode = database !== null;
+ const defaultExtra =
+ '{\n "metadata_params": {},\n "engine_params": {},' +
+ '\n "metadata_cache_timeout": {},\n "schemas_allowed_for_csv_upload": [] \n}';
// Database fetch logic
const {
@@ -589,11 +592,7 @@ const DatabaseModal: FunctionComponent<DatabaseModalProps> = ({
<div className="input-container">
<textarea
name="extra"
- value={db ? db.extra || '' : ''}
- placeholder={
- '{\n "metadata_params": {},\n "engine_params": {},' +
- '\n "metadata_cache_timeout": {},\n "schemas_allowed_for_csv_upload": [] \n}'
- }
+ value={(db && db.extra) ?? defaultExtra}
onChange={onTextChange}
/>
</div>