You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2018/11/28 21:45:44 UTC

[GitHub] jaydoane commented on issue #1769: Add Credo to Elixir test suite

jaydoane commented on issue #1769: Add Credo to Elixir test suite
URL: https://github.com/apache/couchdb/pull/1769#issuecomment-442616448
 
 
   I have a general question about max line length. [This commit](https://github.com/apache/couchdb/commit/df37da6662be6cc62e9c866eee4544000f5329c4) explicitly sets the max line length to 120, up from its default of 96. For Erlang code, the current consensus (and also @davisp's [emelio](https://github.com/cloudant-labs/emilio/blob/master/priv/emilio.config#L23-L24)) appears to be 80, for which there is [ample precedent](https://softwareengineering.stackexchange.com/a/222998). Because it forces you to write more concise code, and it’s great being able to have two code windows open side by side (on a 15" laptop), I hope we also adopt 80 for Elixir code. But I'm curious to what others think it should be.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services