You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "shnus (via GitHub)" <gi...@apache.org> on 2024/04/22 07:52:09 UTC

[PR] IGNITE-22077 Add spring 6 support to spring session extension [ignite-extensions]

shnus opened a new pull request, #262:
URL: https://github.com/apache/ignite-extensions/pull/262

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] IGNITE-22077 Add spring 6 support to spring session extension [ignite-extensions]

Posted by "shishkovilja (via GitHub)" <gi...@apache.org>.
shishkovilja commented on PR #262:
URL: https://github.com/apache/ignite-extensions/pull/262#issuecomment-2126678869

   @nva , @shnus , have been tested it on CI?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] IGNITE-22077 Add spring 6 support to spring session extension [ignite-extensions]

Posted by "nva (via GitHub)" <gi...@apache.org>.
nva merged PR #262:
URL: https://github.com/apache/ignite-extensions/pull/262


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] IGNITE-22077 Add spring 6 support to spring session extension [ignite-extensions]

Posted by "nva (via GitHub)" <gi...@apache.org>.
nva commented on code in PR #262:
URL: https://github.com/apache/ignite-extensions/pull/262#discussion_r1582678077


##########
modules/spring-session-ext/src/main/java/package-info.java:
##########
@@ -19,4 +19,3 @@
  * <!-- Package description. -->
  * Contains classes that allow using Ignite as backing store for storing Spring sessions.
  */
-package org.apache.ignite.spring.sessions;

Review Comment:
   Probably these changes were made by mistake



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] IGNITE-22077 Add spring 6 support to spring session extension [ignite-extensions]

Posted by "shnus (via GitHub)" <gi...@apache.org>.
shnus commented on PR #262:
URL: https://github.com/apache/ignite-extensions/pull/262#issuecomment-2126795482

   > @nva , @shnus , have you tested it on CI [1, 2]? https://ci.ignite.apache.org/ https://ci2.ignite.apache.org/
   
   We've tested on https://ci.ignite.apache.org/
   Do you see any problems?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] IGNITE-22077 Add spring 6 support to spring session extension [ignite-extensions]

Posted by "shishkovilja (via GitHub)" <gi...@apache.org>.
shishkovilja commented on PR #262:
URL: https://github.com/apache/ignite-extensions/pull/262#issuecomment-2126823215

   @shnus , no that's ok. I found that TeamCity build with JDK8 is not successful. I have already checked the same build on TeamCity with JDK17 and there are no problems with it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org