[GitHub] [groovy] eric-milles opened a new pull request #1093: GROOVY-9245: exclude synthetic constructors from CachedClass

[GitBox <gi...@apache.org>]

eric-milles opened a new pull request #1093: GROOVY-9245: exclude synthetic constructors from CachedClass
URL: https://github.com/apache/groovy/pull/1093
 
 
   This has implications for AST transforms (like Builder) that create private methods to be called by other code that they create.  The builder InitializerStrategy makes private constructors and they won't be found by ScriptBytecodeAdapter if marked synthetic.  Maybe `@CompileStatic` can help resolve these constructors at compile time -- also, there is no `setMethodTarget` on `ConstructorCallExpression` to indicate the direct target.
   
   If the risk is not acceptable, then different filter criteria could be used in `CachedClass` to specifically target constructors created for inner class instantiation.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services