You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flex.apache.org by "Vitaliy Parfenov (JIRA)" <ji...@apache.org> on 2013/04/11 11:57:21 UTC
[jira] [Comment Edited] (FLEX-33190) GridEvent.GRID_DOUBLE_CLICK is
dispatched even when two different cells are clicked
[ https://issues.apache.org/jira/browse/FLEX-33190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13628801#comment-13628801 ]
Vitaliy Parfenov edited comment on FLEX-33190 at 4/11/13 9:56 AM:
------------------------------------------------------------------
If we try to apply from patch:
diff --git a/frameworks/projects/spark/src/spark/components/GridColumnHeaderGroup.as b/frameworks/projects/spark/src/spark/components/GridColumnHeaderGroup.as
index 597f6ed..43d5951 100644
--- a/frameworks/projects/spark/src/spark/components/GridColumnHeaderGroup.as
+++ b/frameworks/projects/spark/src/spark/components/GridColumnHeaderGroup.as
@@ -1249,8 +1249,9 @@ public class GridColumnHeaderGroup extends Group implements IDataGridElement
if ((eventSeparatorIndex != -1) && (pressSeparatorIndex == eventSeparatorIndex))
dispatchGridEvent(event, GridEvent.SEPARATOR_DOUBLE_CLICK, eventHeaderXY, eventSeparatorIndex);
- else if ((eventColumnIndex != -1) && (pressColumnIndex == eventColumnIndex))
- dispatchGridEvent(event, GridEvent.GRID_DOUBLE_CLICK, eventHeaderXY, eventColumnIndex);
+//Commented out because it completely bypasses the grids normal doubleclick handler, yet it calls a doubleclick.
+// else if ((eventColumnIndex != -1) && (pressColumnIndex == eventColumnIndex))
+// dispatchGridEvent(event, GridEvent.GRID_DOUBLE_CLICK, eventHeaderXY, eventColumnIndex);
}
/**
then we lose the sorting via click to column header
was (Author: vsp):
If we're try to apply from patch:
diff --git a/frameworks/projects/spark/src/spark/components/GridColumnHeaderGroup.as b/frameworks/projects/spark/src/spark/components/GridColumnHeaderGroup.as
index 597f6ed..43d5951 100644
--- a/frameworks/projects/spark/src/spark/components/GridColumnHeaderGroup.as
+++ b/frameworks/projects/spark/src/spark/components/GridColumnHeaderGroup.as
@@ -1249,8 +1249,9 @@ public class GridColumnHeaderGroup extends Group implements IDataGridElement
if ((eventSeparatorIndex != -1) && (pressSeparatorIndex == eventSeparatorIndex))
dispatchGridEvent(event, GridEvent.SEPARATOR_DOUBLE_CLICK, eventHeaderXY, eventSeparatorIndex);
- else if ((eventColumnIndex != -1) && (pressColumnIndex == eventColumnIndex))
- dispatchGridEvent(event, GridEvent.GRID_DOUBLE_CLICK, eventHeaderXY, eventColumnIndex);
+//Commented out because it completely bypasses the grids normal doubleclick handler, yet it calls a doubleclick.
+// else if ((eventColumnIndex != -1) && (pressColumnIndex == eventColumnIndex))
+// dispatchGridEvent(event, GridEvent.GRID_DOUBLE_CLICK, eventHeaderXY, eventColumnIndex);
}
/**
then we lose the sorting via click to column header
> GridEvent.GRID_DOUBLE_CLICK is dispatched even when two different cells are clicked
> -----------------------------------------------------------------------------------
>
> Key: FLEX-33190
> URL: https://issues.apache.org/jira/browse/FLEX-33190
> Project: Apache Flex
> Issue Type: Bug
> Components: Spark: Grid
> Affects Versions: Apache Flex 4.8 (parity release)
> Reporter: Shigeru Nakagaki
> Assignee: Justin Mclean
> Attachments: 0002-Add-new-support-doubleClickMode.patch, DataGridModeTest.mxml, DataGridTest.mxml
>
>
> In dispatchGridClickEvents method of "s:Grid" class, GridEvent.GRID_DOUBLE_CLICK is dispatched. But there is no check of whether the same cell was clicked.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira