You are viewing a plain text version of this content. The canonical link for it is here.
Posted to c-dev@axis.apache.org by Senaka Fernando <se...@wso2.com> on 2008/02/27 14:32:22 UTC
Re: Fwd: svn commit: r631222 -
/webservices/axis2/trunk/c/util/src/date_time.c
Hi Dinesh,
This is what happens when you make a mistake in the first place and it
propagates and where people begin to live with the mistake. :D...
OK We'd rather revert this.
Regards,
Senaka
> Senaka,
>
> Though this is a trivial bug, it might be caused to break all the
> modules that dependent on this convention. At the door step of the Axis2/C
> 1.3.0 we could not accept such an unstableness in the svn head. I would
> like
> to get revert this change. Lets fix this after Axis2/C 1.3.0 release.
>
> thanks,
> Dinesh
>
> ---------- Forwarded message ----------
> From: <se...@apache.org>
> Date: Tue, Feb 26, 2008 at 7:48 PM
> Subject: svn commit: r631222 -
> /webservices/axis2/trunk/c/util/src/date_time.c
> To: axis2-cvs@ws.apache.org
>
>
> Author: senaka
> Date: Tue Feb 26 06:18:10 2008
> New Revision: 631222
>
> URL: http://svn.apache.org/viewvc?rev=631222&view=rev
> Log:
> Fixing Errors in datetime
>
> Modified:
> webservices/axis2/trunk/c/util/src/date_time.c
>
> Modified: webservices/axis2/trunk/c/util/src/date_time.c
> URL:
> http://svn.apache.org/viewvc/webservices/axis2/trunk/c/util/src/date_time.c?rev=631222&r1=631221&r2=631222&view=diff
> ==============================================================================
> --- webservices/axis2/trunk/c/util/src/date_time.c (original)
> +++ webservices/axis2/trunk/c/util/src/date_time.c Tue Feb 26 06:18:10
> 2008
> @@ -225,9 +225,9 @@
>
> if (year > -1)
> date_time->year = year - 1900;
> - if (month > -1)
> + if (month > 0)
> date_time->mon = month;
> - if (day > -1)
> + if (day > 0)
> date_time->day = day;
> if (hour > -1)
> date_time->hour = hour;
> @@ -288,7 +288,7 @@
>
> date_time_str = AXIS2_MALLOC(env->allocator, sizeof(char) * 32);
> sprintf(date_time_str, "%d-%02d-%02dT%02d:%02d:%02d.%03dZ",
> - date_time->year + 1900, date_time->mon + 1, date_time->day,
> + date_time->year + 1900, date_time->mon, date_time->day,
> date_time->hour, date_time->min, date_time->sec,
> date_time->msec);
> return date_time_str;
> }
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: axis-cvs-unsubscribe@ws.apache.org
> For additional commands, e-mail: axis-cvs-help@ws.apache.org
>
>
>
>
> --
> http://nethu.org/
>
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-c-dev-help@ws.apache.org
Re: Fwd: svn commit: r631222 -
/webservices/axis2/trunk/c/util/src/date_time.c
Posted by Senaka Fernando <se...@wso2.com>.
Done, see diff at [1]
[1]
http://svn.apache.org/viewvc/webservices/axis2/trunk/c/util/src/date_time.c?r1=631202&r2=631586
Will fix this issue after 1.3.0.
Regards,
Senaka
> Hi Dinesh,
>
> This is what happens when you make a mistake in the first place and it
> propagates and where people begin to live with the mistake. :D...
>
> OK We'd rather revert this.
>
> Regards,
> Senaka
>
>> Senaka,
>>
>> Though this is a trivial bug, it might be caused to break all
>> the
>> modules that dependent on this convention. At the door step of the
>> Axis2/C
>> 1.3.0 we could not accept such an unstableness in the svn head. I would
>> like
>> to get revert this change. Lets fix this after Axis2/C 1.3.0 release.
>>
>> thanks,
>> Dinesh
>>
>> ---------- Forwarded message ----------
>> From: <se...@apache.org>
>> Date: Tue, Feb 26, 2008 at 7:48 PM
>> Subject: svn commit: r631222 -
>> /webservices/axis2/trunk/c/util/src/date_time.c
>> To: axis2-cvs@ws.apache.org
>>
>>
>> Author: senaka
>> Date: Tue Feb 26 06:18:10 2008
>> New Revision: 631222
>>
>> URL: http://svn.apache.org/viewvc?rev=631222&view=rev
>> Log:
>> Fixing Errors in datetime
>>
>> Modified:
>> webservices/axis2/trunk/c/util/src/date_time.c
>>
>> Modified: webservices/axis2/trunk/c/util/src/date_time.c
>> URL:
>> http://svn.apache.org/viewvc/webservices/axis2/trunk/c/util/src/date_time.c?rev=631222&r1=631221&r2=631222&view=diff
>> ==============================================================================
>> --- webservices/axis2/trunk/c/util/src/date_time.c (original)
>> +++ webservices/axis2/trunk/c/util/src/date_time.c Tue Feb 26 06:18:10
>> 2008
>> @@ -225,9 +225,9 @@
>>
>> if (year > -1)
>> date_time->year = year - 1900;
>> - if (month > -1)
>> + if (month > 0)
>> date_time->mon = month;
>> - if (day > -1)
>> + if (day > 0)
>> date_time->day = day;
>> if (hour > -1)
>> date_time->hour = hour;
>> @@ -288,7 +288,7 @@
>>
>> date_time_str = AXIS2_MALLOC(env->allocator, sizeof(char) * 32);
>> sprintf(date_time_str, "%d-%02d-%02dT%02d:%02d:%02d.%03dZ",
>> - date_time->year + 1900, date_time->mon + 1, date_time->day,
>> + date_time->year + 1900, date_time->mon, date_time->day,
>> date_time->hour, date_time->min, date_time->sec,
>> date_time->msec);
>> return date_time_str;
>> }
>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: axis-cvs-unsubscribe@ws.apache.org
>> For additional commands, e-mail: axis-cvs-help@ws.apache.org
>>
>>
>>
>>
>> --
>> http://nethu.org/
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org
> For additional commands, e-mail: axis-c-dev-help@ws.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-c-dev-help@ws.apache.org