You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by 1ambda <gi...@git.apache.org> on 2017/06/21 10:55:19 UTC
[GitHub] zeppelin pull request #2424: [ZEPPELIN-2670] fix: DON'T reset all helium con...
GitHub user 1ambda opened a pull request:
https://github.com/apache/zeppelin/pull/2424
[ZEPPELIN-2670] fix: DON'T reset all helium config when saving display order
### What is this PR for?
Reordering vis package using the `save` button resets all helium configuration.
Originally, reported in [ZEPPELIN-2656](https://issues.apache.org/jira/browse/ZEPPELIN-2656) but created a new issue track that problem only.
### What type of PR is it?
[Bug Fix]
### Todos
DONE
### What is the Jira issue?
[ZEPPELIN-2670](https://issues.apache.org/jira/browse/ZEPPELIN-2670)
### How should this be tested?
1. Enable 2 vis packages
2. Change display order
3. Refresh (**necessary**) the page
4. Change display order again
### Screenshots (if appropriate)
#### before
#### after
### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/1ambda/zeppelin ZEPPELIN-2670/saving-helium-vis-order-should-not-reset
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2424.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2424
----
commit 8edfdf75380df098558b4fcd9a3da5fd93a2ea53
Author: 1ambda <1a...@gmail.com>
Date: 2017-06-21T06:31:14Z
style: move getVisualizationPackageOrder func
commit bb66c2bc4703a7e26f95be1a2e33e2d5cbc00cb7
Author: 1ambda <1a...@gmail.com>
Date: 2017-06-21T06:31:36Z
style: Rename setVisualizationPackageOrder
commit d1aea4e85721beae1ddbcc2d0b5b14450850a955
Author: 1ambda <1a...@gmail.com>
Date: 2017-06-21T07:15:14Z
style: reindent saveBundleOrder
commit 13bb650842b530a4f3801ae210d7eb916caf4730
Author: 1ambda <1a...@gmail.com>
Date: 2017-06-21T07:45:16Z
fix: DON'T build when set orders
commit 7159a965c1b19f211f4c935408fc1f25051f4feb
Author: 1ambda <1a...@gmail.com>
Date: 2017-06-21T08:05:38Z
fix: Fetch bundleOrder after getAllPackages
commit 86d960c1ec3c4b32d1eea42f6b2ead5e5d5289b5
Author: 1ambda <1a...@gmail.com>
Date: 2017-06-21T08:15:57Z
fix: DON'T call unncessary init()
commit 04e046e898f5029e203e96968fbf5168afb65931
Author: 1ambda <1a...@gmail.com>
Date: 2017-06-21T10:45:06Z
fix: DON'T reset when getting display order
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2424: [ZEPPELIN-2670] fix: DON'T reset all helium con...
Posted by 1ambda <gi...@git.apache.org>.
GitHub user 1ambda reopened a pull request:
https://github.com/apache/zeppelin/pull/2424
[ZEPPELIN-2670] fix: DON'T reset all helium config when saving display order
### What is this PR for?
Reordering vis package using the `save` button resets all helium configuration.
Originally, reported in [ZEPPELIN-2656](https://issues.apache.org/jira/browse/ZEPPELIN-2656) but created a new issue track that problem only.
### What type of PR is it?
[Bug Fix]
### Todos
DONE
### What is the Jira issue?
[ZEPPELIN-2670](https://issues.apache.org/jira/browse/ZEPPELIN-2670)
### How should this be tested?
1. Enable 2 vis packages
2. Change display order
3. Refresh (**necessary**) the page
4. Change display order again
### Screenshots (if appropriate)
#### before
#### after
### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/1ambda/zeppelin ZEPPELIN-2670/saving-helium-vis-order-should-not-reset
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2424.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2424
----
commit 8edfdf75380df098558b4fcd9a3da5fd93a2ea53
Author: 1ambda <1a...@gmail.com>
Date: 2017-06-21T06:31:14Z
style: move getVisualizationPackageOrder func
commit bb66c2bc4703a7e26f95be1a2e33e2d5cbc00cb7
Author: 1ambda <1a...@gmail.com>
Date: 2017-06-21T06:31:36Z
style: Rename setVisualizationPackageOrder
commit d1aea4e85721beae1ddbcc2d0b5b14450850a955
Author: 1ambda <1a...@gmail.com>
Date: 2017-06-21T07:15:14Z
style: reindent saveBundleOrder
commit 13bb650842b530a4f3801ae210d7eb916caf4730
Author: 1ambda <1a...@gmail.com>
Date: 2017-06-21T07:45:16Z
fix: DON'T build when set orders
commit 7159a965c1b19f211f4c935408fc1f25051f4feb
Author: 1ambda <1a...@gmail.com>
Date: 2017-06-21T08:05:38Z
fix: Fetch bundleOrder after getAllPackages
commit 86d960c1ec3c4b32d1eea42f6b2ead5e5d5289b5
Author: 1ambda <1a...@gmail.com>
Date: 2017-06-21T08:15:57Z
fix: DON'T call unncessary init()
commit 04e046e898f5029e203e96968fbf5168afb65931
Author: 1ambda <1a...@gmail.com>
Date: 2017-06-21T10:45:06Z
fix: DON'T reset when getting display order
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2424: [ZEPPELIN-2670] fix: DON'T reset all helium con...
Posted by 1ambda <gi...@git.apache.org>.
GitHub user 1ambda reopened a pull request:
https://github.com/apache/zeppelin/pull/2424
[ZEPPELIN-2670] fix: DON'T reset all helium config when saving display order
### What is this PR for?
Reordering vis package using the `save` button resets all helium configuration.
Originally, reported in [ZEPPELIN-2656](https://issues.apache.org/jira/browse/ZEPPELIN-2656) but created a new issue track that problem only.
### What type of PR is it?
[Bug Fix]
### Todos
DONE
### What is the Jira issue?
[ZEPPELIN-2670](https://issues.apache.org/jira/browse/ZEPPELIN-2670)
### How should this be tested?
1. Enable 2 vis packages
2. Change display order
3. Refresh (**necessary**) the page
4. Change display order again
### Screenshots (if appropriate)
#### before
#### after
### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/1ambda/zeppelin ZEPPELIN-2670/saving-helium-vis-order-should-not-reset
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2424.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2424
----
commit 8edfdf75380df098558b4fcd9a3da5fd93a2ea53
Author: 1ambda <1a...@gmail.com>
Date: 2017-06-21T06:31:14Z
style: move getVisualizationPackageOrder func
commit bb66c2bc4703a7e26f95be1a2e33e2d5cbc00cb7
Author: 1ambda <1a...@gmail.com>
Date: 2017-06-21T06:31:36Z
style: Rename setVisualizationPackageOrder
commit d1aea4e85721beae1ddbcc2d0b5b14450850a955
Author: 1ambda <1a...@gmail.com>
Date: 2017-06-21T07:15:14Z
style: reindent saveBundleOrder
commit 13bb650842b530a4f3801ae210d7eb916caf4730
Author: 1ambda <1a...@gmail.com>
Date: 2017-06-21T07:45:16Z
fix: DON'T build when set orders
commit 7159a965c1b19f211f4c935408fc1f25051f4feb
Author: 1ambda <1a...@gmail.com>
Date: 2017-06-21T08:05:38Z
fix: Fetch bundleOrder after getAllPackages
commit 86d960c1ec3c4b32d1eea42f6b2ead5e5d5289b5
Author: 1ambda <1a...@gmail.com>
Date: 2017-06-21T08:15:57Z
fix: DON'T call unncessary init()
commit 04e046e898f5029e203e96968fbf5168afb65931
Author: 1ambda <1a...@gmail.com>
Date: 2017-06-21T10:45:06Z
fix: DON'T reset when getting display order
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2424: [ZEPPELIN-2670] fix: DON'T reset all helium con...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda closed the pull request at:
https://github.com/apache/zeppelin/pull/2424
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2424: [ZEPPELIN-2670] fix: DON'T reset all helium con...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2424
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2424: [ZEPPELIN-2670] fix: DON'T reset all helium con...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda closed the pull request at:
https://github.com/apache/zeppelin/pull/2424
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2424: [ZEPPELIN-2670] fix: DON'T reset all helium con...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda closed the pull request at:
https://github.com/apache/zeppelin/pull/2424
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2424: [ZEPPELIN-2670] fix: DON'T reset all helium config whe...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2424
@tinkoff-dwh I created a separated PR for handle the issue what you pointed out.
Could you help review that as well?
- https://github.com/apache/zeppelin/pull/2436
Will merge if no more discussion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2424: [ZEPPELIN-2670] fix: DON'T reset all helium config whe...
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2424
config is rewritten but order in paragraph not changed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2424: [ZEPPELIN-2670] fix: DON'T reset all helium con...
Posted by 1ambda <gi...@git.apache.org>.
GitHub user 1ambda reopened a pull request:
https://github.com/apache/zeppelin/pull/2424
[ZEPPELIN-2670] fix: DON'T reset all helium config when saving display order
### What is this PR for?
Reordering vis package using the `save` button resets all helium configuration.
Originally, reported in [ZEPPELIN-2656](https://issues.apache.org/jira/browse/ZEPPELIN-2656) but created a new issue track that problem only.
### What type of PR is it?
[Bug Fix]
### Todos
DONE
### What is the Jira issue?
[ZEPPELIN-2670](https://issues.apache.org/jira/browse/ZEPPELIN-2670)
### How should this be tested?
1. Enable 2 vis packages
2. Change display order
3. Refresh (**necessary**) the page
4. Change display order again
### Screenshots (if appropriate)
#### before
#### after
### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/1ambda/zeppelin ZEPPELIN-2670/saving-helium-vis-order-should-not-reset
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2424.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2424
----
commit 8edfdf75380df098558b4fcd9a3da5fd93a2ea53
Author: 1ambda <1a...@gmail.com>
Date: 2017-06-21T06:31:14Z
style: move getVisualizationPackageOrder func
commit bb66c2bc4703a7e26f95be1a2e33e2d5cbc00cb7
Author: 1ambda <1a...@gmail.com>
Date: 2017-06-21T06:31:36Z
style: Rename setVisualizationPackageOrder
commit d1aea4e85721beae1ddbcc2d0b5b14450850a955
Author: 1ambda <1a...@gmail.com>
Date: 2017-06-21T07:15:14Z
style: reindent saveBundleOrder
commit 13bb650842b530a4f3801ae210d7eb916caf4730
Author: 1ambda <1a...@gmail.com>
Date: 2017-06-21T07:45:16Z
fix: DON'T build when set orders
commit 7159a965c1b19f211f4c935408fc1f25051f4feb
Author: 1ambda <1a...@gmail.com>
Date: 2017-06-21T08:05:38Z
fix: Fetch bundleOrder after getAllPackages
commit 86d960c1ec3c4b32d1eea42f6b2ead5e5d5289b5
Author: 1ambda <1a...@gmail.com>
Date: 2017-06-21T08:15:57Z
fix: DON'T call unncessary init()
commit 04e046e898f5029e203e96968fbf5168afb65931
Author: 1ambda <1a...@gmail.com>
Date: 2017-06-21T10:45:06Z
fix: DON'T reset when getting display order
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2424: [ZEPPELIN-2670] fix: DON'T reset all helium con...
Posted by 1ambda <gi...@git.apache.org>.
GitHub user 1ambda reopened a pull request:
https://github.com/apache/zeppelin/pull/2424
[ZEPPELIN-2670] fix: DON'T reset all helium config when saving display order
### What is this PR for?
Reordering vis package using the `save` button resets all helium configuration.
Originally, reported in [ZEPPELIN-2656](https://issues.apache.org/jira/browse/ZEPPELIN-2656) but created a new issue track that problem only.
### What type of PR is it?
[Bug Fix]
### Todos
DONE
### What is the Jira issue?
[ZEPPELIN-2670](https://issues.apache.org/jira/browse/ZEPPELIN-2670)
### How should this be tested?
1. Enable 2 vis packages
2. Change display order
3. Refresh (**necessary**) the page
4. Change display order again
### Screenshots (if appropriate)
#### before
#### after
### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/1ambda/zeppelin ZEPPELIN-2670/saving-helium-vis-order-should-not-reset
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2424.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2424
----
commit 8edfdf75380df098558b4fcd9a3da5fd93a2ea53
Author: 1ambda <1a...@gmail.com>
Date: 2017-06-21T06:31:14Z
style: move getVisualizationPackageOrder func
commit bb66c2bc4703a7e26f95be1a2e33e2d5cbc00cb7
Author: 1ambda <1a...@gmail.com>
Date: 2017-06-21T06:31:36Z
style: Rename setVisualizationPackageOrder
commit d1aea4e85721beae1ddbcc2d0b5b14450850a955
Author: 1ambda <1a...@gmail.com>
Date: 2017-06-21T07:15:14Z
style: reindent saveBundleOrder
commit 13bb650842b530a4f3801ae210d7eb916caf4730
Author: 1ambda <1a...@gmail.com>
Date: 2017-06-21T07:45:16Z
fix: DON'T build when set orders
commit 7159a965c1b19f211f4c935408fc1f25051f4feb
Author: 1ambda <1a...@gmail.com>
Date: 2017-06-21T08:05:38Z
fix: Fetch bundleOrder after getAllPackages
commit 86d960c1ec3c4b32d1eea42f6b2ead5e5d5289b5
Author: 1ambda <1a...@gmail.com>
Date: 2017-06-21T08:15:57Z
fix: DON'T call unncessary init()
commit 04e046e898f5029e203e96968fbf5168afb65931
Author: 1ambda <1a...@gmail.com>
Date: 2017-06-21T10:45:06Z
fix: DON'T reset when getting display order
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2424: [ZEPPELIN-2670] fix: DON'T reset all helium con...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda closed the pull request at:
https://github.com/apache/zeppelin/pull/2424
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2424: [ZEPPELIN-2670] fix: DON'T reset all helium con...
Posted by 1ambda <gi...@git.apache.org>.
GitHub user 1ambda reopened a pull request:
https://github.com/apache/zeppelin/pull/2424
[ZEPPELIN-2670] fix: DON'T reset all helium config when saving display order
### What is this PR for?
Reordering vis package using the `save` button resets all helium configuration.
Originally, reported in [ZEPPELIN-2656](https://issues.apache.org/jira/browse/ZEPPELIN-2656) but created a new issue track that problem only.
### What type of PR is it?
[Bug Fix]
### Todos
DONE
### What is the Jira issue?
[ZEPPELIN-2670](https://issues.apache.org/jira/browse/ZEPPELIN-2670)
### How should this be tested?
1. Enable 2 vis packages
2. Change display order
3. Refresh (**necessary**) the page
4. Change display order again
### Screenshots (if appropriate)
#### before
#### after
### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/1ambda/zeppelin ZEPPELIN-2670/saving-helium-vis-order-should-not-reset
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2424.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2424
----
commit 8edfdf75380df098558b4fcd9a3da5fd93a2ea53
Author: 1ambda <1a...@gmail.com>
Date: 2017-06-21T06:31:14Z
style: move getVisualizationPackageOrder func
commit bb66c2bc4703a7e26f95be1a2e33e2d5cbc00cb7
Author: 1ambda <1a...@gmail.com>
Date: 2017-06-21T06:31:36Z
style: Rename setVisualizationPackageOrder
commit d1aea4e85721beae1ddbcc2d0b5b14450850a955
Author: 1ambda <1a...@gmail.com>
Date: 2017-06-21T07:15:14Z
style: reindent saveBundleOrder
commit 13bb650842b530a4f3801ae210d7eb916caf4730
Author: 1ambda <1a...@gmail.com>
Date: 2017-06-21T07:45:16Z
fix: DON'T build when set orders
commit 7159a965c1b19f211f4c935408fc1f25051f4feb
Author: 1ambda <1a...@gmail.com>
Date: 2017-06-21T08:05:38Z
fix: Fetch bundleOrder after getAllPackages
commit 86d960c1ec3c4b32d1eea42f6b2ead5e5d5289b5
Author: 1ambda <1a...@gmail.com>
Date: 2017-06-21T08:15:57Z
fix: DON'T call unncessary init()
commit 04e046e898f5029e203e96968fbf5168afb65931
Author: 1ambda <1a...@gmail.com>
Date: 2017-06-21T10:45:06Z
fix: DON'T reset when getting display order
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2424: [ZEPPELIN-2670] fix: DON'T reset all helium config whe...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2424
Everything about helium is easily broken. we really need tests. Let me test again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2424: [ZEPPELIN-2670] fix: DON'T reset all helium con...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda closed the pull request at:
https://github.com/apache/zeppelin/pull/2424
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---