You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by kkhatua <gi...@git.apache.org> on 2018/04/01 23:11:53 UTC
[GitHub] drill pull request #1199: DRILL-6303: Provide a button to copy the Drillbit'...
GitHub user kkhatua opened a pull request:
https://github.com/apache/drill/pull/1199
DRILL-6303: Provide a button to copy the Drillbit's JStack shown in /threads
Provides a button in the web UI to copy the thread stack to the user's clipboard.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kkhatua/drill DRILL-6303
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/1199.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1199
----
commit 996266b13433538d411094fcaf650b10b6c17d1f
Author: Kunal Khatua <kk...@...>
Date: 2018-03-26T06:09:43Z
DRILL-6303: Provide a button to copy the Drillbit's JStack shown in /threads
Provides a button in the web UI to copy the thread stack to the user's clipboard.
----
---
[GitHub] drill pull request #1199: DRILL-6303: Provide a button to copy the Drillbit'...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/1199
---
[GitHub] drill issue #1199: DRILL-6303: Provide a button to copy the Drillbit's JStac...
Posted by kkhatua <gi...@git.apache.org>.
Github user kkhatua commented on the issue:
https://github.com/apache/drill/pull/1199
@arina-ielchiieva I've made updates based on the review.
I've also skipped adding re-adding the Glyphicons package because we already have that as part of DRILL-6279 (PR #1197 ).
---
[GitHub] drill issue #1199: DRILL-6303: Provide a button to copy the Drillbit's JStac...
Posted by arina-ielchiieva <gi...@git.apache.org>.
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/1199
+1
---
[GitHub] drill issue #1199: DRILL-6303: Provide a button to copy the Drillbit's JStac...
Posted by kkhatua <gi...@git.apache.org>.
Github user kkhatua commented on the issue:
https://github.com/apache/drill/pull/1199
@arina-ielchiieva
I've added 2 snapshots and tested in Chrome.
**Mouse Over**, showing tooltip
**On clicking**, the copy of the text to the clipboard, followed by the alert.
---
[GitHub] drill issue #1199: DRILL-6303: Provide a button to copy the Drillbit's JStac...
Posted by priteshm <gi...@git.apache.org>.
Github user priteshm commented on the issue:
https://github.com/apache/drill/pull/1199
Nice work, @kkhatua! This seems very useful!
---
[GitHub] drill issue #1199: DRILL-6303: Provide a button to copy the Drillbit's JStac...
Posted by arina-ielchiieva <gi...@git.apache.org>.
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/1199
@kkhatua thanks for making the changes, it believe it's very useful but I suggest we do consider some design changes:
1. Information and auto-refresh display as badege and do not hard-code refresh limit.
2. Use glyphicon instead of regular button and move to right side.
3. Simplify tooltip to `Copy to clipboard`.
4. Remove onlick logic.
---