You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by scop <gi...@git.apache.org> on 2016/07/29 16:43:20 UTC
[GitHub] activemq-artemis pull request #689: Fix allowable property check on add in A...
GitHub user scop opened a pull request:
https://github.com/apache/activemq-artemis/pull/689
Fix allowable property check on add in AeroGearConnectorService.handle
Issue found by FindBugs. Not tested, nor really understood, but the code was using a SimpleString to look up things in a String keyed map which won't return anything useful..
Anyway TBH the code looks suspicious to me as AeroGearConstants.ALLOWABLE_PROPERTIES does not contain any properties that start with AEROGEAR_ in the first place, so even though this fix would be correct, it wouldn't probably change anything as the `contains` in the 2nd condition will continue to return false for everything the `startsWith` in the first returns true... maybe there's a further flaw in the logic, but I can't tell as I'm not sure what the specific intent of this block is.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/scop/activemq-artemis ag-allowable-prop
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/689.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #689
----
commit 7c1e8b6f13b742910b4058ba4a68f8ecfc10683e
Author: Ville Skytt� <vi...@iki.fi>
Date: 2016-07-29T16:37:05Z
Fix allowable property check on add in AeroGearConnectorService.handle
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #689: Fix allowable property check on add in AeroGear...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/689
I've been thinking about removing it.. but I will merge it now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #689: Fix allowable property check on add in AeroGear...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/689
I have been thinking of removing Aerogear anyways
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #689: Fix allowable property check on add in A...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/689
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---