You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "kerwin-zk (via GitHub)" <gi...@apache.org> on 2023/10/30 08:57:02 UTC
[PR] [CELEBORN-1097] Optimize the retrieval of configuration in the internalCreateClient [incubator-celeborn]
kerwin-zk opened a new pull request, #2055:
URL: https://github.com/apache/incubator-celeborn/pull/2055
### What changes were proposed in this pull request?
Optimize the retrieval of configuration in the internalCreateClient
### Why are the changes needed?
Directly accessing configuration information through 'conf.xx' in 'internalCreateClient' is time-consuming.
### Does this PR introduce _any_ user-facing change?
### How was this patch tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1097] Optimize the retrieval of configuration in the internalCreateClient [incubator-celeborn]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #2055:
URL: https://github.com/apache/incubator-celeborn/pull/2055#issuecomment-1784769997
We're currently processing your upload. This comment will be updated when the results are available.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1097] Optimize the retrieval of configuration in the internalCreateClient [incubator-celeborn]
Posted by "kerwin-zk (via GitHub)" <gi...@apache.org>.
kerwin-zk commented on PR #2055:
URL: https://github.com/apache/incubator-celeborn/pull/2055#issuecomment-1784890606
> We can refactor the `initializeMemoryAllocator` function to eliminate its dependency on the member variable `TransportClientFactory#conf`. This will allow us to safely remove the `TransportClientFactory#conf` member variable, to prevent performance degradation resulting from erroneous `TransportClientFactory#conf` utilization.
@cfmcgrady Currently, it appears that the 'TransportClientFactory#conf' is mainly used during the initialization of 'TransportClientFactory' and is called only once. Therefore, there is no additional overhead from multiple invocations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1097] Optimize the retrieval of configuration in the internalCreateClient [incubator-celeborn]
Posted by "cfmcgrady (via GitHub)" <gi...@apache.org>.
cfmcgrady commented on PR #2055:
URL: https://github.com/apache/incubator-celeborn/pull/2055#issuecomment-1786313576
thanks, merging to main(v0.4.0)/branch-0.3(v0.3.2).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1097] Optimize the retrieval of configuration in the internalCreateClient [incubator-celeborn]
Posted by "cfmcgrady (via GitHub)" <gi...@apache.org>.
cfmcgrady closed pull request #2055: [CELEBORN-1097] Optimize the retrieval of configuration in the internalCreateClient
URL: https://github.com/apache/incubator-celeborn/pull/2055
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1097] Optimize the retrieval of configuration in the internalCreateClient [incubator-celeborn]
Posted by "cfmcgrady (via GitHub)" <gi...@apache.org>.
cfmcgrady commented on PR #2055:
URL: https://github.com/apache/incubator-celeborn/pull/2055#issuecomment-1784834716
We can refactor the `initializeMemoryAllocator` function to eliminate its dependency on the member variable `TransportClientFactory#conf`. This will allow us to safely remove the `TransportClientFactory#conf` member variable, to prevent performance degradation resulting from erroneous `TransportClientFactory#conf` utilization.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1097] Optimize the retrieval of configuration in the internalCreateClient [incubator-celeborn]
Posted by "cfmcgrady (via GitHub)" <gi...@apache.org>.
cfmcgrady commented on PR #2055:
URL: https://github.com/apache/incubator-celeborn/pull/2055#issuecomment-1784930347
> there is no additional overhead from multiple invocations.
You're correct. I mean we can remove the `TransportClientFactory#conf` variable, as it is only used within the function `initializeMemoryAllocator` when the `TransportClientFactory` is initialized.
https://github.com/apache/incubator-celeborn/blob/70366edb7cef59ff27bdde888b747a897b1f0a2c/common/src/main/java/org/apache/celeborn/common/network/client/TransportClientFactory.java#L71
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1097] Optimize the retrieval of configuration in the internalCreateClient [incubator-celeborn]
Posted by "kerwin-zk (via GitHub)" <gi...@apache.org>.
kerwin-zk commented on PR #2055:
URL: https://github.com/apache/incubator-celeborn/pull/2055#issuecomment-1785087302
@cfmcgrady cc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org