You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Neeru Gupta <gu...@us.ibm.com> on 2016/04/29 21:44:19 UTC
Re: Review Request 46849: Atlas-723: json deserialization regression
due to introduction of state in id
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46849/
-----------------------------------------------------------
(Updated April 29, 2016, 7:44 p.m.)
Review request for atlas and Jeff Hagelberg.
Bugs: ATLAS-723
https://issues.apache.org/jira/browse/ATLAS-723
Repository: atlas
Description
-------
ATLAS 723 json deserialization fix with optional state in id
Diffs
-----
typesystem/src/main/scala/org/apache/atlas/typesystem/json/InstanceSerialization.scala a8389bd26831faed1005969eb686aa64841b3e62
typesystem/src/test/scala/org/apache/atlas/typesystem/json/InstanceSerializationTest.scala 98a97398cfc232a985e7dc7c83c57f00791c3cdb
Diff: https://reviews.apache.org/r/46849/diff/
Testing
-------
New junit test cases are written to verify serialization /deserialization of json
Thanks,
Neeru Gupta
Re: Review Request 46849: Atlas-723: json deserialization regression
due to introduction of state in id
Posted by David Kantor <dk...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46849/#review131342
-----------------------------------------------------------
Ship it!
Ship It!
- David Kantor
On April 29, 2016, 7:44 p.m., Neeru Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46849/
> -----------------------------------------------------------
>
> (Updated April 29, 2016, 7:44 p.m.)
>
>
> Review request for atlas and Jeff Hagelberg.
>
>
> Bugs: ATLAS-723
> https://issues.apache.org/jira/browse/ATLAS-723
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS 723 json deserialization fix with optional state in id
>
>
> Diffs
> -----
>
> typesystem/src/main/scala/org/apache/atlas/typesystem/json/InstanceSerialization.scala a8389bd26831faed1005969eb686aa64841b3e62
> typesystem/src/test/scala/org/apache/atlas/typesystem/json/InstanceSerializationTest.scala 98a97398cfc232a985e7dc7c83c57f00791c3cdb
>
> Diff: https://reviews.apache.org/r/46849/diff/
>
>
> Testing
> -------
>
> New junit test cases are written to verify serialization /deserialization of json
>
>
> Thanks,
>
> Neeru Gupta
>
>
Re: Review Request 46849: Atlas-723: json deserialization regression
due to introduction of state in id
Posted by Jeff Hagelberg <jn...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46849/#review131497
-----------------------------------------------------------
Ship it!
Ship It!
- Jeff Hagelberg
On April 29, 2016, 7:44 p.m., Neeru Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46849/
> -----------------------------------------------------------
>
> (Updated April 29, 2016, 7:44 p.m.)
>
>
> Review request for atlas and Jeff Hagelberg.
>
>
> Bugs: ATLAS-723
> https://issues.apache.org/jira/browse/ATLAS-723
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS 723 json deserialization fix with optional state in id
>
>
> Diffs
> -----
>
> typesystem/src/main/scala/org/apache/atlas/typesystem/json/InstanceSerialization.scala a8389bd26831faed1005969eb686aa64841b3e62
> typesystem/src/test/scala/org/apache/atlas/typesystem/json/InstanceSerializationTest.scala 98a97398cfc232a985e7dc7c83c57f00791c3cdb
>
> Diff: https://reviews.apache.org/r/46849/diff/
>
>
> Testing
> -------
>
> New junit test cases are written to verify serialization /deserialization of json
>
>
> Thanks,
>
> Neeru Gupta
>
>