You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Paul Gier (JIRA)" <ji...@codehaus.org> on 2010/05/14 18:43:12 UTC

[jira] Created: (SUREFIRE-619) The surefire plugin should generate it's own classpath

The surefire plugin should generate it's own classpath
------------------------------------------------------

                 Key: SUREFIRE-619
                 URL: http://jira.codehaus.org/browse/SUREFIRE-619
             Project: Maven Surefire
          Issue Type: Improvement
          Components: classloading, Maven Surefire Plugin
    Affects Versions: 2.5
            Reporter: Paul Gier


I believe the surefire plugin would be improved if it generated it's own classpath instead of getting the test classpath from maven project.  This would allow the user better control over what is included in the classpath, and would actually simplify parts of the code for building the classpath.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (SUREFIRE-619) The surefire plugin should generate it's own classpath

Posted by "Paul Gier (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/SUREFIRE-619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=221256#action_221256 ] 

Paul Gier commented on SUREFIRE-619:
------------------------------------

Just for some additional information, the current surefire classpath is retrieved from MavenProject which basically just returns the paths to all of the dependencies and the classes and test-classes directory.  This requires some hacky logic to fix the paths in the case that the user set a non default location for the classes or test-classes directory in the surefire config.  What I'm trying to do with this issue is figure out a more elegant solution to build the surefire classpath and still allow flexibility for the user to modify this path to fit the needs of the project.

> The surefire plugin should generate it's own classpath
> ------------------------------------------------------
>
>                 Key: SUREFIRE-619
>                 URL: http://jira.codehaus.org/browse/SUREFIRE-619
>             Project: Maven Surefire
>          Issue Type: Improvement
>          Components: classloading, Maven Surefire Plugin
>    Affects Versions: 2.5
>            Reporter: Paul Gier
>            Assignee: Paul Gier
>             Fix For: 2.6
>
>
> I believe the surefire plugin would be improved if it generated it's own classpath instead of getting the test classpath from MavenProject.  This would allow the user better control over what is included in the classpath, and would actually simplify parts of the code for building the classpath.
> The risk associated with this change is that the default surefire classpath could end up being different than the test classpath in MavenProject.  However, I think that as long as the surefire plugin classpath generation is well documented, this won't cause a problem for users.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (SUREFIRE-619) The surefire plugin should generate the test classpath

Posted by "Paul Gier (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/SUREFIRE-619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Paul Gier updated SUREFIRE-619:
-------------------------------

    Description: 
I believe the surefire plugin would be improved if it generated the test classpath internally instead of getting the test classpath from MavenProject.  This would allow the user better control over what is included in the classpath, and would actually simplify parts of the code for building the classpath.

The risk associated with this change is that the default surefire classpath could end up being different than the test classpath in MavenProject.  However, I think that as long as the surefire plugin classpath generation is well documented, this won't cause a problem for users.

  was:
I believe the surefire plugin would be improved if it generated it's own classpath instead of getting the test classpath from MavenProject.  This would allow the user better control over what is included in the classpath, and would actually simplify parts of the code for building the classpath.

The risk associated with this change is that the default surefire classpath could end up being different than the test classpath in MavenProject.  However, I think that as long as the surefire plugin classpath generation is well documented, this won't cause a problem for users.

        Summary: The surefire plugin should generate the test classpath  (was: The surefire plugin should generate it's own classpath)

> The surefire plugin should generate the test classpath
> ------------------------------------------------------
>
>                 Key: SUREFIRE-619
>                 URL: http://jira.codehaus.org/browse/SUREFIRE-619
>             Project: Maven Surefire
>          Issue Type: Improvement
>          Components: classloading, Maven Surefire Plugin
>    Affects Versions: 2.5
>            Reporter: Paul Gier
>            Assignee: Paul Gier
>             Fix For: 2.6
>
>
> I believe the surefire plugin would be improved if it generated the test classpath internally instead of getting the test classpath from MavenProject.  This would allow the user better control over what is included in the classpath, and would actually simplify parts of the code for building the classpath.
> The risk associated with this change is that the default surefire classpath could end up being different than the test classpath in MavenProject.  However, I think that as long as the surefire plugin classpath generation is well documented, this won't cause a problem for users.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (SUREFIRE-619) The surefire plugin should generate it's own classpath

Posted by "Paul Gier (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/SUREFIRE-619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Paul Gier updated SUREFIRE-619:
-------------------------------

    Description: 
I believe the surefire plugin would be improved if it generated it's own classpath instead of getting the test classpath from MavenProject.  This would allow the user better control over what is included in the classpath, and would actually simplify parts of the code for building the classpath.

The risk associated with this change is that the default surefire classpath could end up being different than the test classpath in MavenProject.  However, I think that as long as the surefire plugin classpath generation is well documented, this won't cause a problem for users.

  was:
I believe the surefire plugin would be improved if it generated it's own classpath instead of getting the test classpath from MavenProject.  This would allow the user better control over what is included in the classpath, and would actually simplify parts of the code for building the classpath.

The risk associated with this change is that the default surefire classpath could end up being different than the test classpath in MavenProject.


> The surefire plugin should generate it's own classpath
> ------------------------------------------------------
>
>                 Key: SUREFIRE-619
>                 URL: http://jira.codehaus.org/browse/SUREFIRE-619
>             Project: Maven Surefire
>          Issue Type: Improvement
>          Components: classloading, Maven Surefire Plugin
>    Affects Versions: 2.5
>            Reporter: Paul Gier
>            Assignee: Paul Gier
>             Fix For: 2.6
>
>
> I believe the surefire plugin would be improved if it generated it's own classpath instead of getting the test classpath from MavenProject.  This would allow the user better control over what is included in the classpath, and would actually simplify parts of the code for building the classpath.
> The risk associated with this change is that the default surefire classpath could end up being different than the test classpath in MavenProject.  However, I think that as long as the surefire plugin classpath generation is well documented, this won't cause a problem for users.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (SUREFIRE-619) The surefire plugin should generate it's own classpath

Posted by "Paul Gier (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/SUREFIRE-619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=221255#action_221255 ] 

Paul Gier commented on SUREFIRE-619:
------------------------------------

There are some use cases defined in the two linked issues.  More complete control over the classpath is useful any time you want to run tests against multiple dependency configurations.  The recommendation I've heard in the past is to use multiple separate test projects (POMs) which depend on the project you are testing, but this can be difficult because of SUREFIRE-569.

> The surefire plugin should generate it's own classpath
> ------------------------------------------------------
>
>                 Key: SUREFIRE-619
>                 URL: http://jira.codehaus.org/browse/SUREFIRE-619
>             Project: Maven Surefire
>          Issue Type: Improvement
>          Components: classloading, Maven Surefire Plugin
>    Affects Versions: 2.5
>            Reporter: Paul Gier
>            Assignee: Paul Gier
>             Fix For: 2.6
>
>
> I believe the surefire plugin would be improved if it generated it's own classpath instead of getting the test classpath from MavenProject.  This would allow the user better control over what is included in the classpath, and would actually simplify parts of the code for building the classpath.
> The risk associated with this change is that the default surefire classpath could end up being different than the test classpath in MavenProject.  However, I think that as long as the surefire plugin classpath generation is well documented, this won't cause a problem for users.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (SUREFIRE-619) The surefire plugin should generate it's own classpath

Posted by "Paul Gier (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/SUREFIRE-619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=221265#action_221265 ] 

Paul Gier commented on SUREFIRE-619:
------------------------------------

Moved the classpath generation into a method in the surefire plugin in [r944475|http://svn.apache.org/viewvc?view=revision&revision=944475].

> The surefire plugin should generate it's own classpath
> ------------------------------------------------------
>
>                 Key: SUREFIRE-619
>                 URL: http://jira.codehaus.org/browse/SUREFIRE-619
>             Project: Maven Surefire
>          Issue Type: Improvement
>          Components: classloading, Maven Surefire Plugin
>    Affects Versions: 2.5
>            Reporter: Paul Gier
>            Assignee: Paul Gier
>             Fix For: 2.6
>
>
> I believe the surefire plugin would be improved if it generated it's own classpath instead of getting the test classpath from MavenProject.  This would allow the user better control over what is included in the classpath, and would actually simplify parts of the code for building the classpath.
> The risk associated with this change is that the default surefire classpath could end up being different than the test classpath in MavenProject.  However, I think that as long as the surefire plugin classpath generation is well documented, this won't cause a problem for users.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (SUREFIRE-619) The surefire plugin should generate the test classpath

Posted by "Paul Gier (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/SUREFIRE-619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Paul Gier closed SUREFIRE-619.
------------------------------

    Resolution: Fixed

> The surefire plugin should generate the test classpath
> ------------------------------------------------------
>
>                 Key: SUREFIRE-619
>                 URL: http://jira.codehaus.org/browse/SUREFIRE-619
>             Project: Maven Surefire
>          Issue Type: Improvement
>          Components: classloading, Maven Surefire Plugin
>    Affects Versions: 2.5
>            Reporter: Paul Gier
>            Assignee: Paul Gier
>             Fix For: 2.6
>
>
> I believe the surefire plugin would be improved if it generated the test classpath internally instead of getting the test classpath from MavenProject.  This would allow the user better control over what is included in the classpath, and would actually simplify parts of the code for building the classpath.
> The risk associated with this change is that the default surefire classpath could end up being different than the test classpath in MavenProject.  However, I think that as long as the surefire plugin classpath generation is well documented, this won't cause a problem for users.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (SUREFIRE-619) The surefire plugin should generate it's own classpath

Posted by "Paul Gier (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/SUREFIRE-619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Paul Gier updated SUREFIRE-619:
-------------------------------

    Description: 
I believe the surefire plugin would be improved if it generated it's own classpath instead of getting the test classpath from MavenProject.  This would allow the user better control over what is included in the classpath, and would actually simplify parts of the code for building the classpath.

The risk associated with this change is that the default surefire classpath could end up being different than the test classpath in MavenProject.

  was:I believe the surefire plugin would be improved if it generated it's own classpath instead of getting the test classpath from maven project.  This would allow the user better control over what is included in the classpath, and would actually simplify parts of the code for building the classpath.


> The surefire plugin should generate it's own classpath
> ------------------------------------------------------
>
>                 Key: SUREFIRE-619
>                 URL: http://jira.codehaus.org/browse/SUREFIRE-619
>             Project: Maven Surefire
>          Issue Type: Improvement
>          Components: classloading, Maven Surefire Plugin
>    Affects Versions: 2.5
>            Reporter: Paul Gier
>            Assignee: Paul Gier
>             Fix For: 2.6
>
>
> I believe the surefire plugin would be improved if it generated it's own classpath instead of getting the test classpath from MavenProject.  This would allow the user better control over what is included in the classpath, and would actually simplify parts of the code for building the classpath.
> The risk associated with this change is that the default surefire classpath could end up being different than the test classpath in MavenProject.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (SUREFIRE-619) The surefire plugin should generate it's own classpath

Posted by "Kristian Rosenvold (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/SUREFIRE-619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=221251#action_221251 ] 

Kristian Rosenvold commented on SUREFIRE-619:
---------------------------------------------

I would appreciate some well defined use-cases/scenarios for this?

> The surefire plugin should generate it's own classpath
> ------------------------------------------------------
>
>                 Key: SUREFIRE-619
>                 URL: http://jira.codehaus.org/browse/SUREFIRE-619
>             Project: Maven Surefire
>          Issue Type: Improvement
>          Components: classloading, Maven Surefire Plugin
>    Affects Versions: 2.5
>            Reporter: Paul Gier
>            Assignee: Paul Gier
>             Fix For: 2.6
>
>
> I believe the surefire plugin would be improved if it generated it's own classpath instead of getting the test classpath from MavenProject.  This would allow the user better control over what is included in the classpath, and would actually simplify parts of the code for building the classpath.
> The risk associated with this change is that the default surefire classpath could end up being different than the test classpath in MavenProject.  However, I think that as long as the surefire plugin classpath generation is well documented, this won't cause a problem for users.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (SUREFIRE-619) The surefire plugin should generate it's own classpath

Posted by "Paul Gier (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/SUREFIRE-619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Paul Gier updated SUREFIRE-619:
-------------------------------

    Fix Version/s: 2.6
         Assignee: Paul Gier

> The surefire plugin should generate it's own classpath
> ------------------------------------------------------
>
>                 Key: SUREFIRE-619
>                 URL: http://jira.codehaus.org/browse/SUREFIRE-619
>             Project: Maven Surefire
>          Issue Type: Improvement
>          Components: classloading, Maven Surefire Plugin
>    Affects Versions: 2.5
>            Reporter: Paul Gier
>            Assignee: Paul Gier
>             Fix For: 2.6
>
>
> I believe the surefire plugin would be improved if it generated it's own classpath instead of getting the test classpath from maven project.  This would allow the user better control over what is included in the classpath, and would actually simplify parts of the code for building the classpath.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira