You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2020/12/07 16:24:40 UTC
[kudu-CR] Revert "[thirdparty] Upgrade glog to 0.4.0"
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16824
Change subject: Revert "[thirdparty] Upgrade glog to 0.4.0"
......................................................................
Revert "[thirdparty] Upgrade glog to 0.4.0"
This reverts commit 2943aa701ee092158c2084c614a91f92513ef7c4.
We are still seeing errors in fresh builds on Centos 7 that look like below
with this patch:
[ 6%] Running C++ protocol buffer compiler on hash.proto
--insertions_out: protoc-gen-insertions: Plugin killed by signal 11.
make[2]: *** [src/kudu/util/hash.pb.cc] Error 1
make[1]: *** [src/kudu/util/CMakeFiles/kudu_util_hash_proto.dir/all] Error 2
Change-Id: I5635d1e979be45395d0babdb8c07a234a97a0970
---
M src/kudu/fs/dir_util-test.cc
M src/kudu/util/logging.h
M src/kudu/util/rw_mutex-test.cc
M thirdparty/build-definitions.sh
M thirdparty/download-thirdparty.sh
A thirdparty/patches/glog-fix-symbolization.patch
A thirdparty/patches/glog-issue-198-fix-unused-warnings.patch
A thirdparty/patches/glog-issue-54-dont-build-tests.patch
M thirdparty/patches/glog-support-stacktrace-for-aarch64.patch
M thirdparty/vars.sh
10 files changed, 455 insertions(+), 43 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/24/16824/1
--
To view, visit http://gerrit.cloudera.org:8080/16824
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5635d1e979be45395d0babdb8c07a234a97a0970
Gerrit-Change-Number: 16824
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] Revert "[thirdparty] Upgrade glog to 0.4.0"
Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16824 )
Change subject: Revert "[thirdparty] Upgrade glog to 0.4.0"
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16824
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5635d1e979be45395d0babdb8c07a234a97a0970
Gerrit-Change-Number: 16824
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 07 Dec 2020 17:38:23 +0000
Gerrit-HasComments: No
[kudu-CR] Revert "[thirdparty] Upgrade glog to 0.4.0"
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has removed a vote on this change.
Change subject: Revert "[thirdparty] Upgrade glog to 0.4.0"
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/16824
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I5635d1e979be45395d0babdb8c07a234a97a0970
Gerrit-Change-Number: 16824
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] Revert "[thirdparty] Upgrade glog to 0.4.0"
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16824 )
Change subject: Revert "[thirdparty] Upgrade glog to 0.4.0"
......................................................................
Revert "[thirdparty] Upgrade glog to 0.4.0"
This reverts commit 2943aa701ee092158c2084c614a91f92513ef7c4.
We are still seeing errors in fresh builds on Centos 7 that look like below
with this patch:
[ 6%] Running C++ protocol buffer compiler on hash.proto
--insertions_out: protoc-gen-insertions: Plugin killed by signal 11.
make[2]: *** [src/kudu/util/hash.pb.cc] Error 1
make[1]: *** [src/kudu/util/CMakeFiles/kudu_util_hash_proto.dir/all] Error 2
Change-Id: I5635d1e979be45395d0babdb8c07a234a97a0970
Reviewed-on: http://gerrit.cloudera.org:8080/16824
Tested-by: Grant Henke <gr...@apache.org>
Reviewed-by: Bankim Bhavsar <ba...@cloudera.com>
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/fs/dir_util-test.cc
M src/kudu/util/logging.h
M src/kudu/util/rw_mutex-test.cc
M thirdparty/build-definitions.sh
M thirdparty/download-thirdparty.sh
A thirdparty/patches/glog-fix-symbolization.patch
A thirdparty/patches/glog-issue-198-fix-unused-warnings.patch
A thirdparty/patches/glog-issue-54-dont-build-tests.patch
M thirdparty/patches/glog-support-stacktrace-for-aarch64.patch
M thirdparty/vars.sh
10 files changed, 455 insertions(+), 43 deletions(-)
Approvals:
Grant Henke: Verified
Bankim Bhavsar: Looks good to me, approved
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/16824
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5635d1e979be45395d0babdb8c07a234a97a0970
Gerrit-Change-Number: 16824
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] Revert "[thirdparty] Upgrade glog to 0.4.0"
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16824 )
Change subject: Revert "[thirdparty] Upgrade glog to 0.4.0"
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/16824
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5635d1e979be45395d0babdb8c07a234a97a0970
Gerrit-Change-Number: 16824
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 07 Dec 2020 17:08:54 +0000
Gerrit-HasComments: No
[kudu-CR] Revert "[thirdparty] Upgrade glog to 0.4.0"
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16824 )
Change subject: Revert "[thirdparty] Upgrade glog to 0.4.0"
......................................................................
Patch Set 1: Code-Review+2
It seems we had all the necessary functionality with those extra patches for previous version, so I guess it's OK to keep going with the latter for some time.
--
To view, visit http://gerrit.cloudera.org:8080/16824
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5635d1e979be45395d0babdb8c07a234a97a0970
Gerrit-Change-Number: 16824
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 07 Dec 2020 17:58:43 +0000
Gerrit-HasComments: No