You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/10/25 18:28:23 UTC
[GitHub] [camel-quarkus] ppalaga opened a new pull request, #4214: CxfSoapMtomIT fails in native mode
ppalaga opened a new pull request, #4214:
URL: https://github.com/apache/camel-quarkus/pull/4214
fix #4208
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga merged pull request #4214: CxfSoapMtomIT fails in native mode
Posted by GitBox <gi...@apache.org>.
ppalaga merged PR #4214:
URL: https://github.com/apache/camel-quarkus/pull/4214
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on pull request #4214: CxfSoapMtomIT fails in native mode
Posted by GitBox <gi...@apache.org>.
ppalaga commented on PR #4214:
URL: https://github.com/apache/camel-quarkus/pull/4214#issuecomment-1293477889
> So CxfSoapMtomAwtIT only failed in native mode, but it's JVM mode counterpart CxfSoapMtomAwtTest passed, right?
No that's not really the case. The test passes after changing the signature of the service method from `uploadImage(javax.awt.Image image, String name)` to `uploadImage(ImageData image)` where `ImageData` is just a wrapper for `javax.awt.Image`.
In Quarkiverse CXF I saw the `uploadImage(javax.awt.Image image, String name)` variant to be failing also in JVM mode.
So the question is whether `@MTOM` annotated services require single arg service methods or whether the BLOBs may not occur as service method parameters?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on pull request #4214: CxfSoapMtomIT fails in native mode
Posted by GitBox <gi...@apache.org>.
ppalaga commented on PR #4214:
URL: https://github.com/apache/camel-quarkus/pull/4214#issuecomment-1291670529
> Btw will we remove the non-awt scenario then ?
No, I think both are useful and most importantly, we cannot merge them into a single Maven module, because they have different set of deps.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on pull request #4214: CxfSoapMtomIT fails in native mode
Posted by GitBox <gi...@apache.org>.
ppalaga commented on PR #4214:
URL: https://github.com/apache/camel-quarkus/pull/4214#issuecomment-1293762356
... and strange enough, when I changed
`uploadImage(javax.awt.Image image, String name)`
to
`uploadImage(String image, String name)`
it worked flawlessly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on pull request #4214: CxfSoapMtomIT fails in native mode
Posted by GitBox <gi...@apache.org>.
ppalaga commented on PR #4214:
URL: https://github.com/apache/camel-quarkus/pull/4214#issuecomment-1291675658
> i'm tagging @ffang if he can provide explanation why using directly awt.Image isn't working.
Indeed, @ffang is that expected, that an MTOM service must have the Image BLOB wrapped inside a request/response object ( `uploadImage(ImageData image)`) while the Image blob does not work as a direct service method arg (`uploadImage(Image image, String name)`)? - see here https://github.com/apache/camel-quarkus/pull/4214/files#diff-d9291904f16dd04eb3b85f9c557ac62ae9fc3978b9fa380551a76201f58e2a2aR25-R30
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on pull request #4214: CxfSoapMtomIT fails in native mode
Posted by GitBox <gi...@apache.org>.
ppalaga commented on PR #4214:
URL: https://github.com/apache/camel-quarkus/pull/4214#issuecomment-1293760580
Thanks a lot, I should try whether adding `@RequestWrapper` will make a difference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ffang commented on pull request #4214: CxfSoapMtomIT fails in native mode
Posted by GitBox <gi...@apache.org>.
ffang commented on PR #4214:
URL: https://github.com/apache/camel-quarkus/pull/4214#issuecomment-1292535469
Hi @ppalaga , @llowinge ,
So CxfSoapMtomAwtIT only failed in native mode, but it's JVM mode counterpart CxfSoapMtomAwtTest passed, right?
If so, my gut is that this is something related to the javax.awt.headless in native mode, so that the javax.awt maynot fully working in native mode. As java.awt.Image requires graphic sever(something like X11 server on linux/unix machine), so javax.awt may not work if lack the graphic server or whatnot.
Freeman
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] llowinge commented on pull request #4214: CxfSoapMtomIT fails in native mode
Posted by GitBox <gi...@apache.org>.
llowinge commented on PR #4214:
URL: https://github.com/apache/camel-quarkus/pull/4214#issuecomment-1291555323
Thank you @ppalaga , i'm tagging @ffang if he can provide explanation why using directly `awt.Image` isn't working.
Btw will we remove the non-awt scenario then ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on pull request #4214: CxfSoapMtomIT fails in native mode
Posted by GitBox <gi...@apache.org>.
ppalaga commented on PR #4214:
URL: https://github.com/apache/camel-quarkus/pull/4214#issuecomment-1295140135
Adding an explicit `@RequestWrapper` and `@ResponseWrapper` makes it work in JVM mode https://github.com/quarkiverse/quarkus-cxf/pull/579 It fails in native mode due to some new issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ffang commented on pull request #4214: CxfSoapMtomIT fails in native mode
Posted by GitBox <gi...@apache.org>.
ffang commented on PR #4214:
URL: https://github.com/apache/camel-quarkus/pull/4214#issuecomment-1294113013
Hi @ppalaga ,
I just add a CxfMtomConsumerMutipleParameterTest on my CSB working branch to demonstrate
```
uploadImage(javax.awt.Image image, String name)
```
here https://github.com/ffang/camel-spring-boot-apache/commit/e43b1554dd9a38cbbe3465bf46e108596464994b
and you may want to take a look.
Freeman
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ffang commented on pull request #4214: CxfSoapMtomIT fails in native mode
Posted by GitBox <gi...@apache.org>.
ffang commented on PR #4214:
URL: https://github.com/apache/camel-quarkus/pull/4214#issuecomment-1293599648
>
> So the question is whether `@MTOM` annotated services require single arg service methods or whether the BLOBs may not occur as service method parameters?
No, there is no such requirements from CXF point of view. The signature
```
uploadImage(javax.awt.Image image, String name)
```
definitely should work if being defined correctly. If it doesn't work in your or Quarkiverse CXF, most likely the SEI(service endpoint interface) is incorrect(most likely annotations there not fully follow the JAXWS spec), then this can mess up the service model(what the message payload should be) which is generated from the SEI on the fly. If the SEI in your testcase is handwriting rather than auto-generated from a wsdl, you may run into this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on pull request #4214: CxfSoapMtomIT fails in native mode
Posted by GitBox <gi...@apache.org>.
ppalaga commented on PR #4214:
URL: https://github.com/apache/camel-quarkus/pull/4214#issuecomment-1290976649
cc @llowinge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org