You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apex.apache.org by devtagare <gi...@git.apache.org> on 2016/06/07 22:12:39 UTC

[GitHub] apex-malhar pull request #314: APEXMALHAR-2113 bug fix, app test case,update...

GitHub user devtagare opened a pull request:

    https://github.com/apache/apex-malhar/pull/314

    APEXMALHAR-2113 bug fix, app test case,updated test cases

    @bhupeshchawda could you please review and merge

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/devtagare/incubator-apex-malhar APEXMALHAR-2113-JdbcPOJOOutputOperatorFix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/apex-malhar/pull/314.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #314
    
----
commit d10cfb040a530115bf667333be6c299a9a7baaff
Author: devtagare <de...@gmail.com>
Date:   2016-06-07T18:28:34Z

    APEXMALHAR-2113 bug fix, app test case,updated test cases

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] apex-malhar pull request #314: APEXMALHAR-2113 bug fix, app test case,update...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/apex-malhar/pull/314


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] apex-malhar pull request #314: APEXMALHAR-2113 bug fix, app test case,update...

Posted by bhupeshchawda <gi...@git.apache.org>.
Github user bhupeshchawda commented on a diff in the pull request:

    https://github.com/apache/apex-malhar/pull/314#discussion_r66168863
  
    --- Diff: library/src/main/java/com/datatorrent/lib/db/jdbc/AbstractJdbcTransactionableOutputOperator.java ---
    @@ -34,25 +33,30 @@
     import com.datatorrent.lib.db.AbstractPassThruTransactionableStoreOutputOperator;
     
     /**
    - * This is the base class implementation of a transactionable JDBC output operator.&nbsp;
    - * Subclasses should implement the method which provides the insertion command.
    + * This is the base class implementation of a transactionable JDBC output
    --- End diff --
    
    Please remove the formatting / check-style changes from this PR. Lets have just the relevant changes in this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---