You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/04/08 18:10:30 UTC

[GitHub] [superset] lilykuang commented on a diff in pull request #19626: fix: deactivate embedding on a dashboard

lilykuang commented on code in PR #19626:
URL: https://github.com/apache/superset/pull/19626#discussion_r846369875


##########
superset/dao/base.py:
##########
@@ -175,7 +175,7 @@ def update(
     def delete(cls, model: Model, commit: bool = True) -> Model:
         """
         Generic delete a model
-        :raises: DAOCreateFailedError
+        :raises: DAODeleteFailedError

Review Comment:
   nice catch!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org