[GitHub] [spark] shahidki31 edited a comment on issue #20793: [WIP][SPARK-23643] Shrinking the buffer in hashSeed up to size of the seed parameter

[GitBox <gi...@apache.org>]

shahidki31 edited a comment on issue #20793: [WIP][SPARK-23643] Shrinking the buffer in hashSeed up to size of the seed parameter
URL: https://github.com/apache/spark/pull/20793#issuecomment-472730569
 
 
   > @shahidki31 I'm also kind of confused by this test. I don't see how it would be affected by a random seed. But in retrospect I'm not sure about the assertions. In the test that fails, what is the clustering expected to be? seems like there is only one reasonable clustering into 2 clusters, of 3 and 2 elements respectively?
   
   @srowen This is an exceptional scenario  in case of PIC. Actual result should be cluster size of 4 and 1. If we change to "degree" this test case pass.
   
   It seems when we use "random", PIC is not working well after the changes, might be the reason mentioned by @MaxGekk . Need to analyze further.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org